Skip to content

[5.3] Translation Update#45239

Closed
joomla-translation-bot wants to merge 3 commits intojoomla:5.3-devfrom
joomla-translation-bot:translation5
Closed

[5.3] Translation Update#45239
joomla-translation-bot wants to merge 3 commits intojoomla:5.3-devfrom
joomla-translation-bot:translation5

Conversation

@joomla-translation-bot
Copy link
Contributor

Automatically created pull request based on core-translation repository changes

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Mar 28, 2025
@richard67
Copy link
Member

richard67 commented Mar 28, 2025

@tecpromotion Do you know why this PR shows as last commit a branch update from 5.2-dev? Merge branch 'joomla:5.2-dev' into translation5

If that commit message is auto generated by Git, then that was really a branch update from 5.2-dev, and that just worked fine because the 5.3-dev branch is up to date with 5.2-dev, but it would make trouble if that was not the case and 5.3-dev would be behind 5.2-dev regarding commits.

Is there something left to be changed in the translation update PR stuff?

Or will that be fixed when the default branch will be changed to 5.3-dev?

@brianteeman
Copy link
Contributor

related to #45177 perhaps

@richard67
Copy link
Member

related to #45177 perhaps

@brianteeman Yes. I just see the code in that PR should work, but it hasn't been merged up into 5.3-dev yet. I will work on the upmerge.

@richard67
Copy link
Member

Anyway, this PR here is ok, the possibly wrong branch update did not do any harm as both branches were in synch.

<metadata>
<name>Dutch (nl-BE)</name>
<nativeName>Dutch (Belgium)</nativeName>
<name>Vlaams (nl-BE)</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianteeman
This is fixed in crowdin and can only be fixed with the translation bot when everything is configured correctly.

@richard67
Copy link
Member

@tecpromotion I have just done an upmerge from 5.3-dev and then updated this PR. Now it shows zero changed files, that's expected as there were no new translation changes. Shall we now leave this PR open and the bot will add changes? Or shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants