Skip to content

[5.3] Arrange task types alphabetically#45080

Merged
rdeutz merged 7 commits intojoomla:5.3-devfrom
reem-atalah:5.3-dev-arrange-task-types-alphabetically
Mar 8, 2025
Merged

[5.3] Arrange task types alphabetically#45080
rdeutz merged 7 commits intojoomla:5.3-devfrom
reem-atalah:5.3-dev-arrange-task-types-alphabetically

Conversation

@reem-atalah
Copy link
Contributor

Pull Request for Issue #45069.

Summary of Changes

  • Sorted the task types alphabetically when creating a new task in the Scheduler component.
  • Applied sorting after task options are collected from plugins using usort().
  • Ensured consistent ordering of task types in the UI.

Testing Instructions

Select System → Manage panel → Scheduled Tasks → click New
Verify that task types are displayed in alphabetical order.

Actual result BEFORE applying this Pull Request

Task types appeared in an unordered manner based on how plugins loaded them.
image

Expected result AFTER applying this Pull Request

Task types are always sorted alphabetically, making selection easier.
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@reem-atalah reem-atalah requested a review from richard67 March 5, 2025 23:11
@ghost ghost mentioned this pull request Mar 6, 2025
4 tasks
@richard67 richard67 removed their request for review March 6, 2025 05:46
@ghost
Copy link

ghost commented Mar 6, 2025

I have tested this item ✅ successfully on adb49f7

Test by using the custom update server of the prebuilt packages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

@reem-atalah
Copy link
Contributor Author

Hello @fgsw thanks for testing, Can I know what's next so my code can be merged?

@ghost
Copy link

ghost commented Mar 6, 2025

Can I know what's next so my code can be merged?

@reem-atalah The PR is now RTC. We will just need to wait for maintainer to review and merge it.

Originally posted by @joomdonation in #45065 (comment)

@reem-atalah Please don't double post.

@richard67
Copy link
Member

@reem-atalah The PR is now RTC. We will just need to wait for maintainer to review and merge it.

@fgsw This here not. It still needs one more test.

@reem-atalah When a PR has 2 tests by 2 users who are not the author of the PR, it gets RTC (ready to commit) status and label. Then maintainers will review and merge if ok.

@brianteeman
Copy link
Contributor

@reem-atalah When a PR has 2 tests by 2 users who are not the author of the PR, it gets RTC (ready to commit) status and label. Then maintainers will review and merge if ok.

and just because something is tested the maintainers may decide that its a change or feature that they dont want to accept

@reem-atalah
Copy link
Contributor Author

@fgsw @richard67 @brianteeman thanks for all your clarifications.

@ChristineWk
Copy link

I have tested this item ✅ successfully on adb49f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45080.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 6, 2025
@rdeutz rdeutz enabled auto-merge (squash) March 8, 2025 16:21
@rdeutz rdeutz merged commit cee1192 into joomla:5.3-dev Mar 8, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 8, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Mar 8, 2025

Thanks

@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants