[5.3] remove trashed status from new article page

[reem-atalah]

Pull Request for Issue #44962.

Summary of Changes

Remove the "Trashed" option from the "Status" drop-down list in the New article form.

Testing Instructions

Log in to Joomla! administrator
Toogle Menu -> Content -> Articles
Click on the "New" button
Click on the "Status" Drop down list
You will not see "Trashed" option

Actual result BEFORE applying this Pull Request

The trashed option appears in the status on the new article page

Expected result AFTER applying this Pull Request

The trashed option doesn't appear in the status on the new article page

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Can you still change an article to be trashed?

[charvimehradu]

hi,
the problem with this would be when we actually trash an article, the status would be shown as published (the default) and there would be no option to change the status of the article from the screen of the article. same as @brianteeman asked.

[brianteeman]

I have tested this item 🔴 unsuccessfully on 69c322d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[reem-atalah]

Can you still change an article to be trashed?

yes

[reem-atalah]

hi, the problem with this would be when we actually trash an article, the status would be shown as published (the default). same as @brianteeman asked.

Yes you're right thanks for highlighting this, I'll see it again

[reem-atalah]

I have tested this item 🔴 unsuccessfully on 69c322d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.

Can you give me more information

[brianteeman]

@reem-atalah i marked it as unsuccessful as the issue you are fixing is not to offer trashed as an option when creating a NEW article but what you have done is to remove the ability to mark ANY article as trashed.

[ghost]

I have tested this item 🔴 unsuccessfully on 69c322d

With	Without

Issue #44962 was about new/unsaved articles. Now in saved articles is no Trashedpossible.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[reem-atalah]

Yes I'll handle this now
Appreciated your testing and feedback

[reem-atalah]

@brianteeman @fgsw Hi, I have edited the code and tested it to ensure that all article pages except the new article page have the "Trashed" option.
I appreciate your testing again, thanks in advance.

[brianteeman]

This is looking more promising.

We do not add scripts inline like this. You should make it a standalone script and then it can also be used in all similar forms not just the admin content form.

I am not the best person to guide you on this but if you read https://manual.joomla.org/docs/general-concepts/javascript/adding-javascript/ it should point you in the right direction

[reem-atalah]

Ok I'll see it, thanks for directing me

[reem-atalah]

I can see that the scripts are set in one place which is Joomla-cms/media/com_content/js (in the case of the articles)
But the Media folder is not part of the Joomla-cms repo, it's a library, I have searched in the composer.json, and found "Joomla/MediaWiki", when I opened this repo I didn't find the Media folders, as seen in the Joomla-cms, so it's not the correct place. It's also not mentioned in the link you gave me before. Any clue to find the right place to update in the Media folder to add my js file?

[joomdonation]

You can see source code of our JS in media_source folder. However, what you are doing here in this PR is not the right approach.

For adjusting a form, we should modify code of getForm method to make any adjustment. That would require understand our Form API

For this PR, below are how I would work on:

• We need to remove an option from a ListField, so I first add a method to ListField class to allow removing an option base on the value. The method should be added after addOption method
• Then modify code in getForm method of ArticleModel which I mentioned earlier, call $form->getField('state') to get the state field and then call the removeOption method which is added in earlier step to remove the option (in case $id = 0, for new article).

[ghost]

@reem-atalah Can you change the title (without the issue-number) because the title is used in the changelog.

[reem-atalah]

@joomdonation Thanks a lot for directing me, I'll consider it. Appreciated

[reem-atalah]

@joomdonation @brianteeman @fgsw I updated the PR, I hope it's now as expected, and be able to be merged

[brianteeman]

If you set the article option to use workflow and then try to create or edit an article you get the error

0 Call to undefined method Joomla\CMS\Form\Field\SpacerField::removeTrashedOption()

[reem-atalah]

I can see that SpacerField, ListField, etc. (if there's another) are inherited from FormField, and I think this is the centralized place. Now it works, if there is another case that I can't see please inform me

[reem-atalah]

Updated, I hope now it fits our case

[brianteeman]

I have tested this item ✅ successfully on e9b313a

does what it says -= thanks

maintainers - should this be added to all other new forms (both site and admin)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[reem-atalah]

Hello @brianteeman thanks for testing, Can I know what's next so my code can be merged?

[joomdonation]

I have tested this item ✅ successfully on e9b313a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[joomdonation]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[joomdonation]

@reem-atalah The PR is now RTC. We will just need to wait for maintainer to review and merge it.

[reem-atalah]

@joomdonation Great, thanks for the clarification.

[laoneo]

I would do an instanceof check as the type field can be overwritten and then you can get a field with the type list but it is actually not a ListField class. Probably only on rare cases, but better safe than sorry.

[reem-atalah]

Thanks for the review. I'm considering it now.

[reem-atalah]

@laoneo I changed it, I hope I have your feedback.

[brianteeman]

can someone please remove the RTC status from this as there have been changes since the status was added

[reem-atalah]

can someone please remove the RTC status from this as there have been changes since the status was added

Can I have another feedback and test on it
Thanks for considering my request

[joomdonation]

I have tested this item ✅ successfully on 78f0ba6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[joomdonation]

@fgsw Could you test this PR as well? Should be a quick one.

[ghost]

I have tested this item ✅ successfully on 78f0ba6

Test by using custom update server of prebuilt packages.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[joomdonation]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45065.}

[rdeutz]

We discussed this in the maintainers meeting today and we think it is a valid use case to create an article in the state trashed. I am closing this, thanks for working on this and bringing it on the table.