[6.0] [joomla/database] use createQuery

[heelc29]

Redo of Pull Request #42344.

DRAFT: due temporary update of joomla-framework/database#325

It is recommended to merge after #45827 > MERGED

Summary of Changes

Replaced all fuction calls getQuery(true) with createQuery() but only in database related context.
Note: There is also a getQuery(true) functionality in Joomla\CMS\Uri\Uri that must remain untouched.

Testing Instructions

code review or check logs

Actual result BEFORE applying this Pull Request

Since joomla/database 2.2.0: The parameter $new is deprecated and will be removed in 4.0, use Joomla\Database\DatabaseDriver::createQuery() instead.

Expected result AFTER applying this Pull Request

No warnings for getQuery(true) from core files (still some in session framework)

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[exlemor]

@heelc29 Sadly, I see hundreds of use Joomla\Database\DatabaseDriver::createQuery() instead. - [ROOT]/libraries/vendor/symfony/deprecation-contracts/function.php - Line 25 BEFORE or AFTER the Patch...

I did many different things in the backend such as copy an article, upload an extension, etc etc WITH and WITHOUT the Patch applied and I sifted through ~8mg of deprecated.php log with no foreseeable difference...

What am I doing wrong?

PHP 8.3.19, MariaDB 10.6.15, Joomla 5.3 ßeta 2

[laoneo]

The problem is that getDatabase() returns a DatabaseInterface which doesn't have that function as it is only part of the DatabaseDriver class. So this pr would bind us to the concrete implementation.

[HLeithner]

@heelc29 can you please add this function to the framework database interface for version 4 and rebase this pr on 6.0.

[heelc29]

@heelc29 Sadly, I see hundreds of use Joomla\Database\DatabaseDriver::createQuery() instead. - [ROOT]/libraries/vendor/symfony/deprecation-contracts/function.php - Line 25 BEFORE or AFTER the Patch...

I did many different things in the backend such as copy an article, upload an extension, etc etc WITH and WITHOUT the Patch applied and I sifted through ~8mg of deprecated.php log with no foreseeable difference...

What am I doing wrong?

It is also used for example in joomla framework session so this tries to replace that one caused directly from the cms

Yes the deprecated.php log grows quickly

[heelc29]

@heelc29 can you please add this function to the framework database interface for version 4 and rebase this pr on 6.0.

Sure

[exlemor]

I have tested this item ✅ successfully on 8ee8eeb

I have tested this successfully. Thx @heelc29.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45056.}

[heelc29]

Conflicts resolved.

@Bodge-IT @softforge I think its to late for 6.0.0? Should I rebase to 6.1-dev or is it possible in a patch release?

[joomdonation]

I have tested this item ✅ successfully on 45f9bea

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45056.}

[joomdonation]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45056.}

[Bodge-IT]

Congrats @heelc29, thank you for the PR. Thanks to all involved for reviews, tests, guidance and comments.