[4.x] add createQuery to DatabaseInterface#325
Merged
Hackwar merged 9 commits intojoomla-framework:4.x-devfrom Jun 25, 2025
Merged
[4.x] add createQuery to DatabaseInterface#325Hackwar merged 9 commits intojoomla-framework:4.x-devfrom
Hackwar merged 9 commits intojoomla-framework:4.x-devfrom
Conversation
2 tasks
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Mar 15, 2025
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Mar 15, 2025
Contributor
|
I'd really like to merge this PR, however I would need some documentation for this similar to what is here: https://github.com/joomla-framework/database/blob/3.x-dev/docs/v1-to-v2-update.md |
Contributor
|
Can you also check if you got everything from #311 covered in your PR as well? Then I would close the other PR. |
Contributor
Author
Yes, it contains all changes from #311 without |
Contributor
|
Thank you! It tooks some time, but at least it is now ready in time for the 6.0 CMS release. |
Bodge-IT
pushed a commit
to joomla/joomla-cms
that referenced
this pull request
Sep 25, 2025
* [5.3][joomla/database] use createQuery * temp update joomla-framework/database#325 * update test stubs * update * fix merge conflicts * use 4.x-dev branch of joomla/database * update * Update phpstan-baseline.neon * update * Update composer.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
adds
createQuerytoDatabaseInterfaceTesting Instructions
DatabaseInterfacemust containcreateQueryDocumentation Changes Required
Every class which implements
DatabaseInterfacemust containcreateQuery