Skip to content

[5.3] Use str_contains function for components#44875

Merged
LadySolveig merged 3 commits intojoomla:5.3-devfrom
joomdonation:use_str_contains_for_components
Feb 16, 2025
Merged

[5.3] Use str_contains function for components#44875
LadySolveig merged 3 commits intojoomla:5.3-devfrom
joomdonation:use_str_contains_for_components

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR uses StrContainsRector rector rule to convert code of our components to use str_contains function. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 13, 2025

I have tested this item ✅ successfully on 8a65582


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 8a65582

Carefully reviewed every single change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44875.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2025
@LadySolveig LadySolveig added this to the Joomla! 5.3.0 milestone Feb 15, 2025
@LadySolveig LadySolveig merged commit b69c4c5 into joomla:5.3-dev Feb 16, 2025
0 of 2 checks passed
@LadySolveig
Copy link
Contributor

Thank you @joomdonation and many thanks also to the diligent testers @QuyTon @richard67 💚 💛 💙 ❤️

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 16, 2025
@joomdonation joomdonation deleted the use_str_contains_for_components branch February 16, 2025 03:32
@heelc29 heelc29 mentioned this pull request Feb 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants