Skip to content

[5.3] Change list() to array destruct for modules and plugins code #44970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 3 commits into from
Feb 26, 2025
Merged

[5.3] Change list() to array destruct for modules and plugins code #44970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea36dc0
Change list() to array destruct for modules and plugins code
joomdonation Feb 22, 2025
271f863
CS
joomdonation Feb 22, 2025
d336079
Merge branch '5.3-dev' into use-list-to-array-destruct-for-modules-pl…
QuyTon Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions administrator/modules/mod_menu/src/Menu/CssMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ protected function preprocess($parent)
continue;
}

list($assetName) = isset($query['context']) ? explode('.', $query['context'], 2) : ['com_fields'];
[$assetName] = isset($query['context']) ? explode('.', $query['context'], 2) : ['com_fields'];
} elseif ($item->element === 'com_cpanel' && $item->link === 'index.php') {
continue;
} elseif (
Expand Down Expand Up @@ -382,7 +382,7 @@ protected function preprocess($parent)
continue;
}

list($assetName) = isset($query['extension']) ? explode('.', $query['extension'], 2) : ['com_workflow'];
[$assetName] = isset($query['extension']) ? explode('.', $query['extension'], 2) : ['com_workflow'];
} elseif (\in_array($item->element, ['com_config', 'com_privacy', 'com_actionlogs'], true) && !$user->authorise('core.admin')) {
// Special case for components which only allow super user access
$parent->removeChild($item);
Expand Down
6 changes: 3 additions & 3 deletions plugins/actionlog/joomla/src/Extension/Joomla.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public function onContentAfterSave(Model\AfterSaveEvent $event): void
return;
}

list($option, $contentType) = explode('.', $params->type_alias);
[$option, $contentType] = explode('.', $params->type_alias);

if (!$this->checkLoggable($option)) {
return;
Expand Down Expand Up @@ -272,7 +272,7 @@ public function onContentChangeState(Model\AfterChangeStateEvent $event): void
return;
}

list(, $contentType) = explode('.', $params->type_alias);
[, $contentType] = explode('.', $params->type_alias);

switch ($value) {
case 0:
Expand Down Expand Up @@ -544,7 +544,7 @@ public function onExtensionAfterSave(Model\AfterSaveEvent $event): void
return;
}

list(, $contentType) = explode('.', $params->type_alias);
[, $contentType] = explode('.', $params->type_alias);

if ($isNew) {
$messageLanguageKey = $params->text_prefix . '_' . $params->type_title . '_ADDED';
Expand Down
2 changes: 1 addition & 1 deletion plugins/api-authentication/token/src/Extension/Token.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public function onUserAuthenticate(AuthenticationEvent $event): void
return;
}

list($algo, $userId, $tokenHMAC) = $parts;
[$algo, $userId, $tokenHMAC] = $parts;

/**
* Verify the HMAC algorithm requested in the token string is allowed
Expand Down
6 changes: 3 additions & 3 deletions plugins/system/debug/src/JavascriptRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public function __construct(DebugBar $debugBar, $baseUrl = null, $basePath = nul
*/
public function renderHead()
{
list($cssFiles, $jsFiles, $inlineCss, $inlineJs, $inlineHead) = $this->getAssets(null, self::RELATIVE_URL);
$html = '';
$doc = Factory::getApplication()->getDocument();
[$cssFiles, $jsFiles, $inlineCss, $inlineJs, $inlineHead] = $this->getAssets(null, self::RELATIVE_URL);
$html = '';
$doc = Factory::getApplication()->getDocument();

foreach ($cssFiles as $file) {
$html .= \sprintf('<link rel="stylesheet" type="text/css" href="%s">' . "\n", $file);
Expand Down
2 changes: 1 addition & 1 deletion plugins/user/contactcreator/src/Extension/ContactCreator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public function onUserAfterSave(AfterSaveEvent $event): void

// Check if the contact already exists to generate new name & alias if required
if ($contact->id == 0) {
list($name, $alias) = $this->generateAliasAndName($contact->alias, $contact->name, $categoryId);
[$name, $alias] = $this->generateAliasAndName($contact->alias, $contact->name, $categoryId);

$contact->name = $name;
$contact->alias = $alias;
Expand Down