Skip to content

[5.3] Update npm dependency "joomla-ui-custom-elements" from 0.2.0 to 0.4.1#44888

Merged
laoneo merged 5 commits intojoomla:5.3-devfrom
richard67:5.2-dev-npm-update-joomla-ui-custom-elements-0-4-1
Mar 14, 2025
Merged

[5.3] Update npm dependency "joomla-ui-custom-elements" from 0.2.0 to 0.4.1#44888
laoneo merged 5 commits intojoomla:5.3-devfrom
richard67:5.2-dev-npm-update-joomla-ui-custom-elements-0-4-1

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Feb 13, 2025

Pull Request for Issue #44831 .

Summary of Changes

This pull request (PR) updates the npm dependency "joomla-ui-custom-elements" from version "v0.2.0" to version "0.4.1" and adapts file build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss to the changes from joomla-projects/custom-elements#244 .

List of all changes: joomla-projects/custom-elements@v0.2.0...0.4.1

Besides changes like code style or removal of old, obsolete "webkit-" prefixed stuff, the update contains 2 bug fixes for tabs:

Testing Instructions

Verify that tabs in backend forms like e.g. article edit work as well as before and that there are no visual differences with and without this PR.

Verify issue #44831 .

Verify that alerts (frontend or backend doesn't matter) work as well as before and that there are no visual differences with and without this PR.

Actual result BEFORE applying this Pull Request

Tabs and alerts are working, but the tabs are using the the wrong aria-attributes for the tab-buttons and the tabindex for the button is is not set (issue #44831 ).

Expected result AFTER applying this Pull Request

Tabs and alerts are working, and issue #44831 is fixed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Feb 13, 2025
@richard67 richard67 added a11y Accessibility bug labels Feb 13, 2025
@richard67 richard67 marked this pull request as ready for review February 14, 2025 08:53
@alikon
Copy link
Contributor

alikon commented Mar 13, 2025

i'm a little bit confused this pr shouldn't be on 5.3 ?

btw

i've tested on a 5.3 branch and i've not discovered glitch

@richard67
Copy link
Member Author

i'm a little bit confused this pr shouldn't be on 5.3 ?

When the PR was made we still made bugfixes for 5.2.

i've tested on a 5.3 branch and i've not discovered glitch

You have checked issue #44831 ?

@alikon
Copy link
Contributor

alikon commented Mar 13, 2025

no right now i don't have a "screen reader" in my current setup i hope the issue opener will test that scenario

@richard67
Copy link
Member Author

i hope the issue opener will test that scenario

I hope that, too ... since 1 month.

@richard67 richard67 changed the base branch from 5.2-dev to 5.3-dev March 13, 2025 19:10
@alikon
Copy link
Contributor

alikon commented Mar 13, 2025

i know your pain , fire and forget it's a common practice unfortunately

@richard67 richard67 changed the title [5.2] Update npm dependency "joomla-ui-custom-elements" from 0.2.0 to 0.4.1 [5.3] Update npm dependency "joomla-ui-custom-elements" from 0.2.0 to 0.4.1 Mar 13, 2025
@richard67
Copy link
Member Author

I've pinged her in Mattermost, maybe that helps.

@alikon
Copy link
Contributor

alikon commented Mar 13, 2025

for this reason I have always proposed to close the issues that do not receive updates in let me say for example in 2 weeks, with a bot, but as usual my proposals fall on deaf ears

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 3e6854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 3e6854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.

@brianteeman
Copy link
Contributor

Active tab styling missing

Before

image

image

After

image

image

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on eb566af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Mar 14, 2025

Sorry for the first wrongly successful test...

And here's the VoiceOver test:

Screen.Recording.2025-03-14.at.11.09.41.mov

@angieradtke
Copy link
Contributor

Sorry it took a while. First of all, everything works as desired. The negative tabindex on the tab panel prevents the panel itself from being jumped to. The tab key takes you directly to the first element within the respective panel. This is fine and correct. As long as the panel itself has no name, it cannot be jumped to. The negative tabindex is a kind of safe double bottom that saves the screen reader an empty intermediate step if a name is available. Tested with Jaws on windows

@angieradtke
Copy link
Contributor

I have tested this item ✅ successfully on eb566af

Alle fine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@laoneo laoneo merged commit 59b7f62 into joomla:5.3-dev Mar 14, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@laoneo
Copy link
Member

laoneo commented Mar 14, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 14, 2025
@richard67 richard67 deleted the 5.2-dev-npm-update-joomla-ui-custom-elements-0-4-1 branch March 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility bug NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments