Fixed Issue with createNavs and removeNavs Functions by Correcting .some() Method Usage#241
Merged
HLeithner merged 1 commit intojoomla-projects:masterfrom Feb 13, 2025
Conversation
…e() Method Usage This pull request addresses the issue where the createNavs and removeNavs functions in the navigation system were not executing properly due to incorrect usage of the .some() method. Changes Made: Corrected .some() Method Usage: Removed the .length property from the .some() method in the createNavs and removeNavs functions as .some() returns a boolean and not an array.
Contributor
Author
|
This is my first pull request, I would greatly appreciate any guidance or feedback you can provide. Your insights will help me improve and contribute more effectively in the future. |
DineshNehra29
changed the title
dgrammatiko
approved these changes
Feb 6, 2025
Collaborator
|
@HLeithner this could be merged as well |
Member
|
I already asked for a second review and will merge it then. |
Collaborator
|
Oh, also it needs to run the build command so the tests could run |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
This pull request addresses the issue where the createNavs and removeNavs functions in the navigation system were not executing properly due to incorrect usage of the .some() method.
Changes Made:
Corrected .some() Method Usage:
Removed the .length property from the .some() method in the createNavs and removeNavs functions as .some() returns a boolean and not an array.