[5.3] Silence the SASS deprecations#44870
Closed
dgrammatiko wants to merge 11 commits intojoomla:5.3-devfrom
Closed
[5.3] Silence the SASS deprecations#44870dgrammatiko wants to merge 11 commits intojoomla:5.3-devfrom
dgrammatiko wants to merge 11 commits intojoomla:5.3-devfrom
Conversation
Member
|
Can we silence them only for the vendor folder? |
Contributor
Author
Probably, let me check |
joomla-cms-bot
added
the
NPM Resource Changed
brianteeman
reviewed
Feb 12, 2025
Member
|
The vue fixes are handled here #44852. |
Contributor
Author
I didnt see that PR, will revert |
dgrammatiko
force-pushed
the
5.3-dev/sass
branch
from
5bcb5b2 to
8680aa5
Compare
joomla-cms-bot
removed
the
NPM Resource Changed
Member
|
Would that mean that when we add a deprecation in one of these files that they are not visible in the build output? |
Contributor
Author
|
The scss files are still visible in the output of the tool, it's just for them we suppress the deprecations logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed