[5.3] Fix code style in vue files and and also exit 1 when warnings

[laoneo]

Pull Request for Issue #44816.

Summary of Changes

Fixes the code style issues. Additionally the code style command exits with a none 0 status when warnings do happen.

Testing Instructions

Check drone javascript cs check or run the following command in the joomla root folder:
eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .

Actual result BEFORE applying this Pull Request

Warnings are displayed when running the code style check.

Expected result AFTER applying this Pull Request

No warnings when running the code style check.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

@laoneo Does this PR close the referred issue #44816 ?

[laoneo]

Yes

[richard67]

Yes

@laoneo Then you should have commented in the issue and closed the issue.

[laoneo]

I just wanted to let drone finish as I changed the exit code. It makes no sense to close the issue when the pr would be invalid. One step after the other.

[alikon]

I have tested this item ✅ successfully on 89667cd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.}

[richard67]

I have tested this item ✅ successfully on 89667cd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.}

[richard67]

@rdeutz It seems you have merged this PR with a merge commit and not a squash commit as the commit history of the 5.3-dev branch now shows the single commits from this PR. Not a big thing as it were only 6 commits, so I see no need to revert. But I think I should at least notify you.