Skip to content

[5.2] Rename update SQL scripts 5.2.0-2024-09-24.sql to 5.2.1-2024-09-24.sql#44388

Merged
Hackwar merged 1 commit intojoomla:5.2-devfrom
richard67:5.2-dev-fix-update-sql-file-name
Nov 1, 2024
Merged

[5.2] Rename update SQL scripts 5.2.0-2024-09-24.sql to 5.2.1-2024-09-24.sql#44388
Hackwar merged 1 commit intojoomla:5.2-devfrom
richard67:5.2-dev-fix-update-sql-file-name

Conversation

@richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

The update SQL scripts "5.2.0-2024-09-24.sql" which were added with PR #44133 should have been renamed to "5.2.1-2024-09-24.sql" before merging because 5.2.0 was already released at that time.

This PR here does that now.

If a 5.2.1 will be released in the next days which does not contain these files because it only fixes the file system permissions, they have to be renamed again to "5.2.2-2024-09-24.sql".

The wrong file name is not a problem for updating as the date is newer than the newest 5.2.0 script present before an update, so the version of the file is still newer than the schema version in the database before the update, and so the script will run.

But it should have the right version in its name so nobody is confused.

Testing Instructions

Code review, and check if the files "5.2.0-2024-09-24.sql" can be found in a 5.2.0 installation or update package.

Actual result BEFORE applying this Pull Request

Update SQL scripts are named "5.2.0-2024-09-24.sql" but can't be found in a 5.2.0.

Expected result AFTER applying this Pull Request

Update SQL scripts are named "5.2.1-2024-09-24.sql".

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 8ae1636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Nov 1, 2024

I have tested this item ✅ successfully on 8ae1636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

@alikon
Copy link
Contributor

alikon commented Nov 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-5.2-dev labels Nov 1, 2024
@Hackwar Hackwar merged commit 6808902 into joomla:5.2-dev Nov 1, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.1 milestone Nov 1, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 1, 2024

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants