[5.2] Rename update SQL scripts 5.2.0-2024-09-24.sql to 5.2.1-2024-09-24.sql#44388
Merged
Hackwar merged 1 commit intojoomla:5.2-devfrom Nov 1, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 8ae1636 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 8ae1636 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388. |
Member
|
Thank you for your contribution! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The update SQL scripts "5.2.0-2024-09-24.sql" which were added with PR #44133 should have been renamed to "5.2.1-2024-09-24.sql" before merging because 5.2.0 was already released at that time.
This PR here does that now.
If a 5.2.1 will be released in the next days which does not contain these files because it only fixes the file system permissions, they have to be renamed again to "5.2.2-2024-09-24.sql".
The wrong file name is not a problem for updating as the date is newer than the newest 5.2.0 script present before an update, so the version of the file is still newer than the schema version in the database before the update, and so the script will run.
But it should have the right version in its name so nobody is confused.
Testing Instructions
Code review, and check if the files "5.2.0-2024-09-24.sql" can be found in a 5.2.0 installation or update package.
Actual result BEFORE applying this Pull Request
Update SQL scripts are named "5.2.0-2024-09-24.sql" but can't be found in a 5.2.0.
Expected result AFTER applying this Pull Request
Update SQL scripts are named "5.2.1-2024-09-24.sql".
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed