Skip to content

[5.2] Translation for Publish & Feature#44133

Merged
pe7er merged 10 commits intojoomla:5.2-devfrom
Kostelano:5-2-pub-and-fut
Oct 20, 2024
Merged

[5.2] Translation for Publish & Feature#44133
pe7er merged 10 commits intojoomla:5.2-devfrom
Kostelano:5-2-pub-and-fut

Conversation

@Kostelano
Copy link
Contributor

@Kostelano Kostelano commented Sep 24, 2024

Pull Request for Issue # .

Summary of Changes

Set a language that is clearly different from English. Go to the Users --- Manage menu, in the User Groups column, select Permissions. A little lower in the list there will be a line Publish & Feature (com_content.transition.7) without translation.

The same on the Users: Groups ---> Permissions page.

Screenshot_1

PR fixes this small problem, now we see the line translated.

UPD
Added files to update translation strings for #__assets.
Test by installing the UPDATE package on your 5.2 test sites.

@brianteeman
Copy link
Contributor

Good spot. This was missed from [4.0] Make transitions translateable #35457

You will need to add an update sql for this as well. Check that PR and you will see what is needed

@richard67
Copy link
Member

richard67 commented Sep 24, 2024

@Hackwar Does this count as new feature so it should go into 5.3-dev? Or is it ok for 5.2-dev?

Update September 25: Was discussed in maintainers meeting today. 5.2-dev is fine.

@Quy
Copy link
Contributor

Quy commented Sep 28, 2024

I have tested this item ✅ successfully on 048f044


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44133.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Sep 29, 2024

I have tested this item ✅ successfully on 048f044


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44133.

@alikon
Copy link
Contributor

alikon commented Sep 29, 2024

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44133.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2024
@pe7er pe7er self-assigned this Oct 18, 2024
@pe7er pe7er added this to the Joomla! 5.2.1 milestone Oct 20, 2024
@pe7er pe7er enabled auto-merge (squash) October 20, 2024 12:55
@pe7er pe7er merged commit efc4a5d into joomla:5.2-dev Oct 20, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 20, 2024
@pe7er
Copy link
Contributor

pe7er commented Oct 20, 2024

Thanks @Kostelano !

@richard67
Copy link
Member

@pe7er You should have checked the names of the update SQL scripts added by this PR before merging. The PR was merged after the release of 5.2.0, so they should have been renamed from "5.2.0-2024-09-24.sql" to "5.2.1-2024-09-24.sql". I've made a PR to fix that: #44388 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants