[5.2] Fix multi-line comment indentation in system test javascript#44368
Merged
laoneo merged 1 commit intojoomla:5.2-devfrom Oct 29, 2024
Merged
[5.2] Fix multi-line comment indentation in system test javascript#44368laoneo merged 1 commit intojoomla:5.2-devfrom
laoneo merged 1 commit intojoomla:5.2-devfrom
Conversation
2 tasks
Member
|
Thanks! |
Member
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) changes indentation of a multi-line comment in file
tests/System/plugins/db.mjs.The comment had been added with PR #44092 .
The javascript-cs check in Drone is ok with that comment in the 5.2-dev branch, but when doing the upmerge PR #44367 for the 5.3-dev branch I've noticed that it makes that check in Drone fail on that branch.
The reason for that difference is PR #44296 , which was merged in the 5.3-dev branch and updates our linter commands to support mjs.
I think it should be fixed in the 5.2-dev branch, so I've made this PR here. I will later care for the conflict in my upmerge PR when this one here will be merged before that one.
Testing Instructions
Code review, and check if the javascript-cs step passes in Drone.
Actual result BEFORE applying this Pull Request
The javascript-cs step passes in Drone.
The comment changed by this PR here is 2 spaces more indented than the code blockes above and below.
Expected result AFTER applying this Pull Request
The javascript-cs step still passes in Drone.
Indentation of the comment changed by this PR here is the same as for the code blockes above and below.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed