[5.3] Move to ESM redo of #43779#44296
Merged
LadySolveig merged 1 commit intojoomla:5.3-devfrom Oct 17, 2024
Merged
Conversation
45e65d2 to
c46ba3f
Compare
Contributor
|
I have tested this item ✅ successfully on 5800f30 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44296. |
Contributor
|
Thank you @dgrammatiko 💚 🚀 |
This was referenced Oct 29, 2024
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Nov 13, 2024
2 tasks
bembelimen
pushed a commit
that referenced
this pull request
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
build/media_source/system/js/joomla-core-loader.mjsfile now includes the required css and the relatedbuild/media_source/system/scss/joomla-core-loader.scssis deletedTesting Instructions
You need Git and NPM to test this
Pull the
5.3-devbranch and run:npm installnpm run cssversioningnpm run gzipnpm run versioningjoomla-cmsfolderPull this PR
gh pr checkout 43781and run:npm installnpm run cssversioningnpm run gzipnpm run versioningjoomla-cmsfolderCompare the two folders. The only difference should be the missing files:
media/system/css/joomla-core-loader.css,media/system/css/joomla-core-loader.min.css,media/system/css/joomla-core-loader.min.css.gzCheck the basic backend functionality
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed