[4.x] Fix settings component parameters of menuitems via API#44119
Merged
MacJoom merged 7 commits intojoomla:4.4-devfrom Sep 25, 2024
Merged
[4.x] Fix settings component parameters of menuitems via API#44119MacJoom merged 7 commits intojoomla:4.4-devfrom
MacJoom merged 7 commits intojoomla:4.4-devfrom
Conversation
wilsonge
reviewed
Sep 20, 2024
Contributor
|
I have tested this item ✅ successfully on 84ac7f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119. |
Member
|
I have tested this item ✅ successfully on 84ac7f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119. |
Contributor
|
Thank you! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes the creation new menuitems if created via the webservices API. The bug fixed prevented API calls from setting component-specific parameters, as the component parameters were not joined in the form preprocessing.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Example request payload
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed