Skip to content

[4.4][Performance] Fix duplicated DB queries for ActionLog language loading#44077

Merged
MacJoom merged 2 commits intojoomla:4.4-devfrom
Fedik:fix-actionLog-lang-load
Sep 25, 2024
Merged

[4.4][Performance] Fix duplicated DB queries for ActionLog language loading#44077
MacJoom merged 2 commits intojoomla:4.4-devfrom
Fedik:fix-actionLog-lang-load

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Sep 14, 2024

Pull Request for Issue # .

Summary of Changes

Fix duplicated DB queries for ActionLog language loading

Testing Instructions

Visit Home Dashboard with "Latest Actions" module enabled (with few actions in it).
Enable debug and debug Query in the debug plugin.
Check amount of DB queries in debug panel.

Actual result BEFORE applying this Pull Request

In my test was 41

Expected result AFTER applying this Pull Request

In my test was 36 (5 less, depend how many latest actions in the module)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added bug Small A PR which only has a small change labels Sep 14, 2024
@ghost
Copy link

ghost commented Sep 14, 2024

I have tested this item ✅ successfully on 294c202

Queries without Pull Request: 44
Queries with Pull Request: 39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44077.

@Quy
Copy link
Contributor

Quy commented Sep 14, 2024

I have tested this item ✅ successfully on 294c202


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44077.

@Quy
Copy link
Contributor

Quy commented Sep 14, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44077.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 14, 2024
@richard67 richard67 added Performance and removed bug labels Sep 15, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.9 milestone Sep 25, 2024
@MacJoom MacJoom merged commit 8f37e3c into joomla:4.4-dev Sep 25, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 25, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Sep 25, 2024

Thank you!

@Fedik Fedik deleted the fix-actionLog-lang-load branch September 26, 2024 07:08
Hackwar added a commit that referenced this pull request Sep 29, 2024
Fix ActionLog duplicated query while language loading (#44077)
Fix settings component parameters of menuitems via API (#44119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Performance PR-4.4-dev Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants