Skip to content

[4.4] Improve translation of aria label text by extra language keys #44050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laoneo merged 6 commits into from
Sep 11, 2024
Merged

[4.4] Improve translation of aria label text by extra language keys #44050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac0e2eb
Improve translation of aria label text by extra language keys
chmst Sep 9, 2024
795c54f
Update layouts/joomla/pagination/link.php
chmst Sep 10, 2024
acc3880
Update layouts/joomla/pagination/link.php
chmst Sep 10, 2024
ba7faa0
Update layouts/joomla/pagination/link.php
chmst Sep 10, 2024
9fa3463
Update layouts/joomla/pagination/link.php
chmst Sep 10, 2024
16364f9
Merge branch '4.4-dev' into a11y-pagination-aria-labels
QuyTon Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions administrator/language/en-GB/lib_joomla.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,10 @@ JLIB_HTML_FEATURED_PENDING_ITEM="Featured, but is Pending."
JLIB_HTML_FEATURED_STARTED="Start: %s"
JLIB_HTML_GOTO_PAGE="Go to page %s"
JLIB_HTML_GOTO_POSITION="Go to %s page"
JLIB_HTML_GOTO_POSITION_END="Go to last page"
JLIB_HTML_GOTO_POSITION_NEXT="Go to next page"
JLIB_HTML_GOTO_POSITION_PREVIOUS="Go to previous page"
JLIB_HTML_GOTO_POSITION_START="Go to first page"
JLIB_HTML_ITEM_PUBLISHED_BUT_CATEGORY_TRASHED="Published but the category is trashed."
JLIB_HTML_ITEM_PUBLISHED_BUT_CATEGORY_UNPUBLISHED="Published but the category is not published."
JLIB_HTML_MOVE_DOWN="Move Down"
Expand Down
4 changes: 4 additions & 0 deletions language/en-GB/lib_joomla.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,10 @@ JLIB_HTML_FEATURED_PENDING_ITEM="Featured, but is Pending."
JLIB_HTML_FEATURED_STARTED="Start: %s"
JLIB_HTML_GOTO_PAGE="Go to page %s"
JLIB_HTML_GOTO_POSITION="Go to %s page"
JLIB_HTML_GOTO_POSITION_END="Go to last page"
JLIB_HTML_GOTO_POSITION_NEXT="Go to next page"
JLIB_HTML_GOTO_POSITION_PREVIOUS="Go to previous page"
JLIB_HTML_GOTO_POSITION_START="Go to first page"
JLIB_HTML_MOVE_DOWN="Move Down"
JLIB_HTML_MOVE_UP="Move Up"
JLIB_HTML_NO_PARAMETERS_FOR_THIS_ITEM="There are no parameters for this item."
Expand Down
9 changes: 4 additions & 5 deletions layouts/joomla/pagination/link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,25 @@
// Check for "Start" item
case Text::_('JLIB_HTML_START'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-double-right' : 'icon-angle-double-left';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_START');
break;

// Check for "Prev" item
case $item->text === Text::_('JPREV'):
$item->text = Text::_('JPREVIOUS');
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-right' : 'icon-angle-left';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_PREVIOUS');
break;

// Check for "Next" item
case Text::_('JNEXT'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-left' : 'icon-angle-right';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_NEXT');
break;

// Check for "End" item
case Text::_('JLIB_HTML_END'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-double-left' : 'icon-angle-double-right';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_END');
break;

default:
Expand Down