Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Sep 9, 2024

Pull Request for Issue #44040 .

Summary of Changes

Use different language Keys for Pagination Buttons. This enables better translation.

Testing Instructions

See #44040. For english sites, The Aria Labels in pagination are correct before and after patch.
Text can then be translated correcty.
For Example German "Gehe zur nächsten Seite" statt

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

"Zur Seite weiter wechseln" is not a correct german sentence.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels Sep 9, 2024
@chmst chmst added the a11y Accessibility label Sep 9, 2024
@chmst chmst changed the title Improve translation of aria label text by extra language keys [4.4] Improve translation of aria label text by extra language keys Sep 9, 2024
@brianteeman
Copy link
Contributor

I am surprised at the way the current code creates the language strings. I can't see why it was created that way.
I am also surprised that no translation team has raised this issue before.

As the text in the core doesn't change and at least one language will be improved by this change then its all good by me

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ac0e2eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.

1 similar comment
@ghost
Copy link

ghost commented Sep 10, 2024

I have tested this item ✅ successfully on ac0e2eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.

@brianteeman
Copy link
Contributor

oops I missed the code change that @sandewt spotted.

@chmst
Copy link
Contributor Author

chmst commented Sep 10, 2024

oops - missed it too.. thank you @sandewt

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9fa3463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Sep 10, 2024

I have tested this item ✅ successfully on 9fa3463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.

@Quy
Copy link
Contributor

Quy commented Sep 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 10, 2024
Copy link
Contributor

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chmst

@laoneo laoneo merged commit 94d9664 into joomla:4.4-dev Sep 11, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 11, 2024
@laoneo
Copy link
Member

laoneo commented Sep 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility Language Change This is for Translators PR-4.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants