-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.4] Improve translation of aria label text by extra language keys #44050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am surprised at the way the current code creates the language strings. I can't see why it was created that way. As the text in the core doesn't change and at least one language will be improved by this change then its all good by me |
|
I have tested this item ✅ successfully on ac0e2eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050. |
1 similar comment
|
I have tested this item ✅ successfully on ac0e2eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050. |
|
oops I missed the code change that @sandewt spotted. |
|
oops - missed it too.. thank you @sandewt |
Co-authored-by: jsanders <[email protected]>
Co-authored-by: jsanders <[email protected]>
Co-authored-by: jsanders <[email protected]>
Co-authored-by: jsanders <[email protected]>
|
I have tested this item ✅ successfully on 9fa3463 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050. |
1 similar comment
|
I have tested this item ✅ successfully on 9fa3463 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050. |
tecpromotion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chmst
|
Thanks! |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
joomla/joomla-cms#43980 - (только для др. пакетов) joomla/joomla-cms#44005 - (только для др. пакетов) joomla/joomla-cms#44050 +
Pull Request for Issue #44040 .
Summary of Changes
Use different language Keys for Pagination Buttons. This enables better translation.
Testing Instructions
See #44040. For english sites, The Aria Labels in pagination are correct before and after patch.
Text can then be translated correcty.
For Example German "Gehe zur nächsten Seite" statt
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
"Zur Seite weiter wechseln" is not a correct german sentence.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed