Merged
Conversation
4 tasks
brianteeman
reviewed
Aug 14, 2024
brianteeman
reviewed
Aug 14, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Member
|
Thank you for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for pr #43819.
Summary of Changes
Integrates PHPStan into core. It uses the CMS setup from #43819 and the stubs, reflection and dynamic return types from the DPDocker code analyze task. The later can be used by extension developers in a similar way how the CMS is using it by including the build/phpstan/phpstan.neon into the main phpstan.neon of their extension.
Testing Instructions
Is all for system tests only, but if you want to check it out locally, do a
composer installof the branch and thenlibraries/vendor/bin/phpstanon the command line.