[5.2] Adding phpstan to drone setup#43819
Closed
Hackwar wants to merge 3 commits intojoomla:5.2-devfrom
Closed
Conversation
Member
Member
|
#43919 is a more enhanced alternative to this one. |
Member
Author
|
Since we have a better version of this, closing this one. Thanks @laoneo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the phpstan static code analyser to our composer dependencies and to our drone setup. It is configured to ignore a series of false positives and to list all deprecations as well. Its configuration file is excluded from the build script. For now phpstan is only set to scan in level 0. When all reports from that are fixed, we can raise that level gradually. Since phpstan will throw failures for a long time, failures are set to be ignored in drone.
phpstan also allows to register a baseline of errors right now and then throw errors when the result differs from that baseline, but that is something for the future.
Testing Instructions
See phpstan step in drone and its results.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed