Skip to content

Avoid strlen for admin submenu items #43884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdeutz merged 9 commits into from
Oct 31, 2024
Merged

Avoid strlen for admin submenu items #43884

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
692afac
Avoid strlen for admin submenu items
chmst Aug 5, 2024
ba979db
as requestd
chmst Aug 7, 2024
363f44e
Update administrator/components/com_menus/src/Model/MenutypesModel.php
laoneo Aug 7, 2024
87df381
Update administrator/components/com_menus/src/Model/MenutypesModel.php
QuyTon Aug 7, 2024
88e9534
Update administrator/components/com_menus/src/Model/MenutypesModel.php
QuyTon Aug 7, 2024
df46b34
Merge branch '4.4-dev' into admin-menu-contains-array
chmst Aug 9, 2024
a030f80
Merge branch '5.2-dev' into admin-menu-contains-array
rdeutz Oct 31, 2024
07cd00b
Update MenutypesModel.php
rdeutz Oct 31, 2024
599ca76
Merge branch '5.2-dev' into admin-menu-contains-array
Hackwar Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion administrator/components/com_menus/src/Model/MenutypesModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,14 @@ protected function getTypeOptionsFromManifest($component)
$request['sub'] = (string) $attributes->sub;
}

$o->request = array_filter($request, 'strlen');
$o->request = array_filter($request, function ($value) {
if (\is_array($value)) {
return !empty($value);
}

return \strlen($value);
});

$options[] = new CMSObject($o);

// Do not repeat the default view link (index.php?option=com_abc).
Expand Down