Avoid strlen for admin submenu items#43884
Merged
rdeutz merged 9 commits intojoomla:5.2-devfrom Oct 31, 2024
Merged
Conversation
This was referenced Aug 6, 2024
Fedik
reviewed
Aug 6, 2024
administrator/components/com_menus/src/Model/MenutypesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Aug 7, 2024
administrator/components/com_menus/src/Model/MenutypesModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
Quy
reviewed
Aug 7, 2024
administrator/components/com_menus/src/Model/MenutypesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Aug 7, 2024
administrator/components/com_menus/src/Model/MenutypesModel.php
Outdated
Show resolved
Hide resolved
Originally posted by @Hackwar in #43715 (comment) Can someone tell me where to find the "manifest"-file for "com_content" or another component (i can't trigger the bug)? |
Contributor
|
Please rebase for 5.2. |
Contributor
|
I have tested this item ✅ successfully on df46b34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on df46b34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request for Issue #43715, #39758
Credits @Hackwar
Summary of Changes
Remove empty values from request
Testing Instructions
see #43715, #39758
Actual result BEFORE applying this Pull Request
Error message when adding or editing a menuItemType in some cases - see description in #43715, #39758
Expected result AFTER applying this Pull Request
MenuItemTypes can be selected and edited
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed