Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
|
Thanks for the work. I do not like renaming under For the build script it looks much better there. Because there is actual ESM now. |
@Fedik it's just a convention, but now we have way less options, which, normally, should be easier for every contributor |
yeah |
|
I have tested this item ✅ successfully on 6b3316b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43779. |
|
Thanks for your hard work on this. Unfortunately 4.4 is in maintenance mode, where we merge mainly bug fixes. To not risk to have the 4.4-dev unstable and prevent side effects in the ecosystem, I'm closing this one for now as the move to ESM should be done in an active development branch, which is currently 5.2. Thanks for understanding. |
|
@laoneo the only reason I backported the changes was to make it easier for devs when they'll have to push a change from 4.4 to 5/6. Anyways np |
Pull Request for Issue # .
Summary of Changes
.mjs(used to be.es6.js).mjsextension (used to be.w-c.es6.js)build/media_source/system/js/joomla-core-loader.mjsfile now includes the required css and the relatedbuild/media_source/system/scss/joomla-core-loader.scssis deletedTesting Instructions
You need Git and NPM to test this
Pull the
4.4-devbranch and run:npm installnpm run gzipnpm run versioningjoomla-cmsfolderPull this PR
gh pr checkout 43779and run:npm installnpm run gzipnpm run versioningjoomla-cmsfolderCompare the two folders. The only difference should be the missing files:
media/system/css/joomla-core-loader.css,media/system/css/joomla-core-loader.min.css,media/system/css/joomla-core-loader.min.css.gzCheck that basic backend functionality
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@Fedik @richard67 could you please test this one (pretty hard for the average tester)?
@LadySolveig @bembelimen please DO NOT upmerge this, I will do a PR on the 5.1 instead