Skip to content

[cypress] lint mjs files#43778

Merged
laoneo merged 6 commits intojoomla:4.4-devfrom
heelc29:4.4/lint-systems-tests
Sep 2, 2024
Merged

[cypress] lint mjs files#43778
laoneo merged 6 commits intojoomla:4.4-devfrom
heelc29:4.4/lint-systems-tests

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jul 12, 2024

Follow up Pull Request for #43676 .

Summary of Changes

Some files are renamed from *.js to *.mjs, but the lint:testjs command has not been updated to the new file extension

Testing Instructions

npm run lint:testjs

Actual result BEFORE applying this Pull Request

*.mjs are not tested (eslint) in javascript-cs

Expected result AFTER applying this Pull Request

*.mjs are tested (eslint) in javascript-cs

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Unit/System Tests labels Jul 12, 2024
@dgrammatiko
Copy link
Contributor

@heelc29 actually the follow up PR should be #43779...

@laoneo laoneo self-assigned this Aug 16, 2024
@laoneo laoneo added this to the Joomla! 4.4.9! milestone Aug 29, 2024
@laoneo laoneo merged commit 0442977 into joomla:4.4-dev Sep 2, 2024
@laoneo
Copy link
Member

laoneo commented Sep 2, 2024

Thanks!

@heelc29 heelc29 deleted the 4.4/lint-systems-tests branch September 2, 2024 16:07
@heelc29 heelc29 mentioned this pull request Nov 11, 2024
heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Nov 12, 2024
laoneo pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Unit/System Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants