Closed
Conversation
[5.2] Upmerge 2024-03-14
[5.2] Upmerge 2024-03-27
[5.2] Upmerge 2024-04-03
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
[5.2] Change all calls for AbstractView::document getDocument()
[5.2] Adding missing type hints for $this
[5.2] Upmerge 2024-04-11
[5.2] Upmerge 2024-04-18
[5.2] Deprecate WebApplication::$JComponentTitle
[5.2] Upmerge 2024-06-18
[5.2] Upmerge 2024-07-02
* Show next run, show list by next run and show a warning when there are due tasks * Update administrator/components/com_scheduler/src/Model/TasksModel.php * Update administrator/components/com_scheduler/src/Model/TasksModel.php * Update administrator/language/en-GB/com_scheduler.ini Co-authored-by: Quy <quy@nomonkeybiz.com> * fix default ordering * Update administrator/language/en-GB/com_scheduler.ini Co-authored-by: Quy <quy@nomonkeybiz.com> * Dont fix things outside of the scope of this PR ---------
[5.2] Upmerge 2024-07-09
Contributor
|
I have tested this item ✅ successfully on 84a4222 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43773. |
Member
|
@artur-stepien The typos exist already in 4.4 so they should be fixed in the 4.4-dev branch. Release managers will later merge it up to the other branches when it has been merged into 4.4-dev. Could you rebase to or redo on the 4.4-dev branch? Thanks in advance. |
|
I have tested this item ✅ successfully on 84a4222 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43773. |
artur-stepien
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo and
rdeutz
as code owners
Member
|
@chmst @ChristineWk New PR for 4.4-dev is #43888 . Could you "test" that one, too? Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the comment in captcha object as it's clearly wrong.
Summary of Changes
Just fixing 2 comments to match what they describe.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed