[5.2] Router: Check directly for RouterInterface#43119
Merged
wilsonge merged 1 commit intojoomla:5.2-devfrom Mar 22, 2024
Merged
[5.2] Router: Check directly for RouterInterface#43119wilsonge merged 1 commit intojoomla:5.2-devfrom
wilsonge merged 1 commit intojoomla:5.2-devfrom
Conversation
Member
|
I have tested this item ✅ successfully on 062d2f9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43119. |
Member
Author
|
For 6.0 we should enforce the interface by typehinting the input vars properly. |
Contributor
|
Trivial change so merging with a single good test + my code review |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I have no idea why I took this complicated approach of using Reflection to see if the given object implements the RouterInterface. This PR changes the code to be simpler and to just use the instanceof operator.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed