Fix chevron color in module menu assignment#43645
Merged
pe7er merged 4 commits intojoomla:5.2-devfrom Jun 18, 2024
RickR2H:fix-chevron
Merged
Fix chevron color in module menu assignment#43645pe7er merged 4 commits intojoomla:5.2-devfrom RickR2H:fix-chevron
pe7er merged 4 commits intojoomla:5.2-devfrom
RickR2H:fix-chevron
Conversation
Added empty line at the end
Contributor
|
I have tested this item ✅ successfully on 8cc4aaf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 8cc4aaf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645. |
Contributor
|
Something sees odd here - the css being changed was only recently added #43160 Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour |
Member
Author
|
PR is closed due to some solution is merged already #43160. |
Contributor
|
This PR is needed.
|
Member
Author
|
@brianteeman Re-opened |
Member
Author
|
Was closed before so the successful tests where reset. No code has been changed so added the tests and RTC status again. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645. |
Contributor
|
Thanks @RickR2H ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The chevron in the Module menu Assignment in light mode is not visible. In dark mode the chevron is visible.
I used the default link color as new color.
Testing Instructions
Actual result BEFORE applying this Pull Request
Chevron not visible
Expected result AFTER applying this Pull Request
Chevron is visible