[5.1] Dark Mode menu select toggle colour#43160
Merged
LadySolveig merged 2 commits intojoomla:5.1-devfrom Mar 27, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on d9bd44a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
Contributor
|
I have tested this item ✅ successfully on d9bd44a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
Contributor
|
Thank you @brianteeman and also for testing @viocassel @Quy |
Contributor
Author
|
thanks |
Member
|
@brianteeman I commited to the 5.2 branch. I think you PR was not up-merged. That why I didn't notice it. I'll close my PR and I'll wait for the up-merge. |
Contributor
Author
|
No your PR is needed. This was upmerged but
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
final part Pull Request for Issue #43068 .
Summary of Changes
Change the colour of the icon in the treeselect for assigning modules to pages to satisfy contrast rules
Testing Instructions
see #43068 for more details
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed