[5.1] SEF: Change value for trailingslash option#43195
Merged
bembelimen merged 3 commits intojoomla:5.1-devfrom Apr 7, 2024
Merged
[5.1] SEF: Change value for trailingslash option#43195bembelimen merged 3 commits intojoomla:5.1-devfrom
bembelimen merged 3 commits intojoomla:5.1-devfrom
Conversation
Contributor
|
Am I missing some information here/ Is this instead of #43024 ? |
Member
Author
|
This PR tries to get this change still into 5.1 without enabling the SEF stuff for new installations. |
Contributor
|
ah - so you are saying this is an alternative proposal. Would be good to be clearer in the description |
Member
|
Wouldn't it need to "migrate" values when updating from 5.1.0 Beta 1 or Beta 2 or RC? Otherwise it could happen that the functionality is enabled when the value is 0. @LadySolveig @bembelimen What do you think? |
Contributor
|
Thx |
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR implements parts of #43024. In Joomla 6.0, the
nonebehavior is going to be dropped again. When that is the case, it will be difficult to explain why the switch contains the values 1 and 2.Testing Instructions
codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed