[5.2] SEF: Enable new SEF options for new installations#43024
Merged
pe7er merged 11 commits intojoomla:5.2-devfrom Aug 15, 2024
Merged
[5.2] SEF: Enable new SEF options for new installations#43024pe7er merged 11 commits intojoomla:5.2-devfrom
pe7er merged 11 commits intojoomla:5.2-devfrom
Conversation
Contributor
|
shouldnt the default value in the xml match the value being set in the install sql? |
Member
Author
|
No, because the default for existing installations should be the current behavior, not the new behavior. If I set the default to the value in the installation SQL, then a user editing the SEF plugin, not changing anything and then saving would have the new behavior. |
4 tasks
Contributor
|
I have tested this item ✅ successfully on d03b7bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
Contributor
|
I have tested this item ✅ successfully on f64664b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
Contributor
|
Thanks @Hackwar ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR enables the new SEF features for new installations by default. It also changes the value of the trailingslash option. In Joomla 6.0 we want to remove the "Do nothing" option again and it would be stupid to then have to switch between the values 1 and 2 instead of 0 and 1.
Testing Instructions
Codereview?
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed