[4.4] Postinstallation-Message htaccess.txt brotli change#43173
Merged
laoneo merged 3 commits intojoomla:4.4-devfrom Mar 28, 2024
Merged
[4.4] Postinstallation-Message htaccess.txt brotli change#43173laoneo merged 3 commits intojoomla:4.4-devfrom
laoneo merged 3 commits intojoomla:4.4-devfrom
Conversation
Quy
reviewed
Mar 28, 2024
administrator/components/com_admin/postinstall/htaccessbrotli.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
Member
|
I have tested this item ✅ successfully on e3200de This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43173. |
Contributor
|
not sure what will happen when someone who has updated to 4.4.4 then goes to 5.1 - worse case i think is that they will see the message twice |
Member
@brianteeman Check my comments in your PR. The message will not be duplicated as we have the |
Contributor
|
which is why I said "not sure" ;) |
Member
|
Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postinstallation-Message for Brotli compression bug #43055
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request