Merged
Conversation
Add support for brotli gzip compression in htaccess.txt
brianteeman
reviewed
Mar 16, 2024
fix description Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
I have tested this item ✅ successfully on 33d2ff1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43055. |
Contributor
Author
|
INFO: It seems that with ngix instead of apache the problem does not occur |
Contributor
|
I have tested this item ✅ successfully on 33d2ff1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43055. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43055. |
Member
|
Thanks! |
Contributor
|
Hi @brianteeman - we need a Post-Installation Message for the change in the htaccess.txt - as a native speaker could you suggest a message? As we are building the RC release this evening this is urgent. Sorry for the hurry. Please ping me if you are busy. Thank you |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for brotli gz compression in htaccess.txt
From Wikipedia:
Summary of Changes
Webservers that use brotli and have Joomla's htaccess enabled will fail the website in HTTPS unless you comment/delete the code block related to GZIP.
After the change, the problem no longer occurs.
Testing Instructions
htaccess.txtto.htaccessActual result BEFORE applying this Pull Request
If your hosting does not use brotli
Joomla works properly
If your hosting use brotli
Joomla in HTTP works correctly.
Joomla in HTTPS does not load the CSS and JS resources, and investigating the error in the console is:
ERR_CONTENT_DECODING_FAILEDExpected result AFTER applying this Pull Request
If your hosting does not use brotli
Joomla still works properly
If your hosting use brotli
Joomla works properly
NOTE
ServerPlan uses brotli.
Thanks
Thanks to ServerPlan for supporting the tests and finding the solution
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed