Skip to content

[5.1] Finder: Allow finder plugins to output spaces #43093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bembelimen merged 1 commit into from
Mar 27, 2024
Merged

[5.1] Finder: Allow finder plugins to output spaces #43093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions administrator/components/com_finder/src/Controller/IndexerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ public function start()

$output = ob_get_contents();

if ($output) {
// Finder plugins should not create output of any kind. If there is output, that very likely is the result of a PHP error.
if (trim($output)) {
throw new \Exception(Text::_('COM_FINDER_AN_ERROR_HAS_OCCURRED'));
}

Expand Down Expand Up @@ -201,7 +202,8 @@ public function batch()

$output = ob_get_contents();

if ($output) {
// Finder plugins should not create output of any kind. If there is output, that very likely is the result of a PHP error.
if (trim($output)) {
throw new \Exception(Text::_('COM_FINDER_INDEXER_ERROR_PLUGIN_FAILURE'));
}

Expand Down Expand Up @@ -251,7 +253,8 @@ public function optimize()

$output = ob_get_contents();

if ($output) {
// Finder plugins should not create output of any kind. If there is output, that very likely is the result of a PHP error.
if (trim($output)) {
throw new \Exception(Text::_('COM_FINDER_AN_ERROR_HAS_OCCURRED'));
}

Expand Down