[5.1] Finder: Allow finder plugins to output spaces#43093
Merged
bembelimen merged 1 commit intojoomla:5.1-devfrom Mar 27, 2024
Merged
[5.1] Finder: Allow finder plugins to output spaces#43093bembelimen merged 1 commit intojoomla:5.1-devfrom
bembelimen merged 1 commit intojoomla:5.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on af165ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on af165ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093. |
|
For anyone stumbling on this before 5.1 is released. These were the symptoms that lead me to this fix in my case:
|
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43000 .
Summary of Changes
Finder plugins should not generate any output when being run. If they create output, we expect this to be the output of notices, errors or warnings from PHP directly. This check has been added in 5.0, however some finder plugins out there seem to generate output, most likely from switching between PHP and HTML context. This PR makes this a bit less strict by allowing spaces and new line characters as output. I consider this an acceptable compromise.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed