Skip to content

[5.1] Finder: Allow finder plugins to output spaces#43093

Merged
bembelimen merged 1 commit intojoomla:5.1-devfrom
Hackwar:5.1-finder-trim
Mar 27, 2024
Merged

[5.1] Finder: Allow finder plugins to output spaces#43093
bembelimen merged 1 commit intojoomla:5.1-devfrom
Hackwar:5.1-finder-trim

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 19, 2024

Pull Request for Issue #43000 .

Summary of Changes

Finder plugins should not generate any output when being run. If they create output, we expect this to be the output of notices, errors or warnings from PHP directly. This check has been added in 5.0, however some finder plugins out there seem to generate output, most likely from switching between PHP and HTML context. This PR makes this a bit less strict by allowing spaces and new line characters as output. I consider this an acceptable compromise.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Mar 19, 2024

I have tested this item ✅ successfully on af165ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on af165ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.

@Quy Quy removed the bug label Mar 19, 2024
@Quy
Copy link
Contributor

Quy commented Mar 19, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 19, 2024
@Quy Quy added the bug label Mar 19, 2024
@Hackwar Hackwar closed this Mar 22, 2024
@Hackwar Hackwar deleted the 5.1-finder-trim branch March 22, 2024 10:56
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 22, 2024
@Hackwar Hackwar restored the 5.1-finder-trim branch March 22, 2024 10:57
@Hackwar Hackwar reopened this Mar 22, 2024
@Quy
Copy link
Contributor

Quy commented Mar 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 22, 2024
@35grain
Copy link

35grain commented Mar 27, 2024

For anyone stumbling on this before 5.1 is released. These were the symptoms that lead me to this fix in my case:

  • The useful message A "finder" plugin has had an error. in everything.php log.
  • The error Error An error has occurred while fetching the JSON data: HTTP 502 status code. Bad gateway. in the Smart Search Indexer modal.

@bembelimen bembelimen merged commit 86bdf28 into joomla:5.1-dev Mar 27, 2024
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 27, 2024
@Hackwar Hackwar deleted the 5.1-finder-trim branch June 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants