[6.0] Switching Input object from CMS to framework class#42805
Merged
laoneo merged 11 commits intojoomla:6.0-devfrom Feb 26, 2024
Merged
[6.0] Switching Input object from CMS to framework class#42805laoneo merged 11 commits intojoomla:6.0-devfrom
laoneo merged 11 commits intojoomla:6.0-devfrom
Conversation
….0-input # Conflicts: # administrator/components/com_actionlogs/src/Controller/ActionlogsController.php # installation/src/Application/InstallationApplication.php # libraries/src/Application/AdministratorApplication.php # libraries/src/Application/BaseApplication.php # libraries/src/Application/CMSApplication.php # libraries/src/Application/SiteApplication.php # libraries/src/Application/WebApplication.php
Hackwar
requested review from
HLeithner,
chmst,
laoneo and
rdeutz
as code owners
joomla-cms-bot
added
Language Change
joomla-cms-bot
removed
Language Change
Member
|
Just for reference, this is a redo of #40415. |
Member
|
Can you also create an entry in the manual? |
laoneo
added
the
b/c break
Member
Author
|
Documentation has been added. |
4 tasks
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
Joomla\CMS\Inputpackage has been deprecated and we have theJoomla\Input\Inputpackage from the framework instead. This converts all occurences of the CMS package over to the framework package. This especially fixes the issue that our application baseclass,Joomla\Application\AbstractWebApplication, uses the framework classes, while all child classes in the CMS use the CMS classes.Testing Instructions
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Adding removal of CMS Input object to 6.0 notes Manual#224
No documentation changes for manual.joomla.org needed