-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Dark mode for Joomla 5.1 #42757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode for Joomla 5.1 #42757
Conversation
Thanks! Co-authored-by: Brian Teeman <[email protected]>
…a-cms into dark-mode-5.0-dev
Improve colors of Language overrides
Dark mode 5.1 dev ccc
I didn't know that the dark theme has a white background for the text. |
|
Sorry that was a mistake in my text, i meant link color on dark and white on link color. Cassiopeia is totally unrelated to the backend template. |
|
@LadySolveig i think all the outstanding issues are fixed can we merge and create afterwards separate PRs if something comes up? |
Revert "Dark mode 5.1 dev ccc"
…-dev-ccc Revert "Revert "Dark mode 5.1 dev ccc""
|
@coolcat-creations @MacJoom Please remove the block of testing code in the template |
|
Already reverted actually |
Not sure where its reverted because it is still present in this pr |
I only can make PRs to the other PR I cant do a separate PR because this is not merged yet, so we always need to wait until its resolved in the main. Thats also the reason why I am begging to merge this so fixes can be done in smaller PRs |
Of course you can - you make it to MacJoom:dark-mode-5.1-dev |
|
Which I did, thats what I am saying :-) |
|
so just ask @MacJoom to merge it or to gicve you access on his repo to merge it. That shouldnt be a reason to merge a pr here that is known not to be ready |
Revert changes to index
|
I did already and he did, I only told you that Its reverted already. Still standing by my point that it would be easier if we have smaller PRs this is hard to work on |
|
Please fix file conflict. |
|
Closed in favour of #42986 |





Pull Request for Issue # .
This is the rebase of #42010 for Joomla 5.1
Summary of Changes
Dark mode colors
Testing Instructions
Turn on dark mode in your browser or O/S
Actual result BEFORE applying this Pull Request
old colors
Expected result AFTER applying this Pull Request
new colors
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed