Skip to content

Conversation

@MacJoom
Copy link
Contributor

@MacJoom MacJoom commented Feb 4, 2024

Pull Request for Issue # .

This is the rebase of #42010 for Joomla 5.1

Summary of Changes

Dark mode colors

Testing Instructions

Turn on dark mode in your browser or O/S

Actual result BEFORE applying this Pull Request

old colors

Expected result AFTER applying this Pull Request

new colors

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

MacJoom and others added 30 commits September 30, 2023 19:47
Thanks!

Co-authored-by: Brian Teeman <[email protected]>
@korenevskiy
Copy link
Contributor

korenevskiy commented Mar 4, 2024

No I was talking only about the dark theme

I didn't know that the dark theme has a white background for the text.
Sorry. Alas.
How deep is the edit to make. I would suggest that you definitely plan to add it after making this PR.
Have the participants already discussed the plans for a new template based on cassiopeia?
I hope you will agree that my suggestion of link colors is important.

@coolcat-creations
Copy link
Contributor

Sorry that was a mistake in my text, i meant link color on dark and white on link color. Cassiopeia is totally unrelated to the backend template.

@coolcat-creations
Copy link
Contributor

@LadySolveig i think all the outstanding issues are fixed can we merge and create afterwards separate PRs if something comes up?

@brianteeman
Copy link
Contributor

@coolcat-creations @MacJoom Please remove the block of testing code in the template

image

@coolcat-creations
Copy link
Contributor

Already reverted actually

@brianteeman
Copy link
Contributor

image

image

@brianteeman
Copy link
Contributor

Already reverted actually

Not sure where its reverted because it is still present in this pr

@coolcat-creations
Copy link
Contributor

Already reverted actually

Not sure where its reverted because it is still present in this pr

I only can make PRs to the other PR I cant do a separate PR because this is not merged yet, so we always need to wait until its resolved in the main. Thats also the reason why I am begging to merge this so fixes can be done in smaller PRs

@brianteeman
Copy link
Contributor

I only can make PRs to the other PR

Of course you can - you make it to MacJoom:dark-mode-5.1-dev

@coolcat-creations
Copy link
Contributor

Which I did, thats what I am saying :-)

@brianteeman
Copy link
Contributor

so just ask @MacJoom to merge it or to gicve you access on his repo to merge it. That shouldnt be a reason to merge a pr here that is known not to be ready

@brianteeman
Copy link
Contributor

image

The new template screenshots in this PR are not used as they are jpg but the code is looking for png

image

@coolcat-creations
Copy link
Contributor

I did already and he did, I only told you that Its reverted already. Still standing by my point that it would be easier if we have smaller PRs this is hard to work on

@Quy
Copy link
Contributor

Quy commented Mar 4, 2024

Please fix file conflict.

@bembelimen
Copy link
Contributor

Closed in favour of #42986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.