[5.0] Dark mode for Joomla 5.0 - Version 2

[MacJoom]

Pull Request for Issue # .

Dark mode redesign thanks to @coolcat-creations

Work in progress! (e.g. Notifications revert bg/fg, sample data)

Summary of Changes

Color, Border, Box-shadow changes

Testing Instructions

Turn on Dark Mode in your browser

Actual result BEFORE applying this Pull Request

old colors

Expected result AFTER applying this Pull Request

new colors, borders, shadows

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Where is var(--bg-color-hvr); defined - I couldn't see it and it results in problems such as this on hover

[brianteeman]

Note to anyone testing. You need to test atum in both light and dark modes

[wilsonge]

Before testing specific things - it feels like the colors in the menu bars take all the attention away from the main component area. Especially the left menu.

[coolcat-creations]

Before testing specific things - it feels like the colors in the menu bars take all the attention away from the main component area. Especially the left menu.

I think that's still WIP because some colors are not done yet I will try to help when back in office.

[brianteeman]

@HLeithner @MacJoom Is this still intended to be merged for 5.0? I ask because there are issues in the already merged dark-mode code but there is no point in fixing it if this PR will change it all again

[HLeithner]

no 5.0.0 is closed, might be considered for 5.0.1

[brianteeman]

So what should be done regarding existing dark mode bugs

[HLeithner]

will be fixed in 5.0.1

[brianteeman]

So I go back to my original question but change 5.0 to 5.0.1

Is this still intended to be merged for 5.0.1? I ask because there are issues in the already merged dark-mode code but there is no point in fixing it if this PR will change it all again

Happy to contribute but donty want to waste time and effort

[HLeithner]

I have to discuss with the team what is really happening in ths pr and what's happening another pr, as long as this pr touches only the dark mode and doesn't break light mode it will go into 5.0.1+

[brianteeman]

it currently breaks light mode :(

[brianteeman]

what is happening with this PR. Have we been wasting our time working on release blockers

[HLeithner]

which release blocker has fix here? this pr is unlikly to be merged into 5.0.0, my target version would be 5.0.1

[Milo-W]

I have a question.
How do you turn dark mode off?
Nowhere to be found...

[coolcat-creations]

I have a question. How do you turn dark mode off? Nowhere to be found...

In the Browser :)

[brianteeman]

which release blocker has fix here? this pr is unlikly to be merged into 5.0.0, my target version would be 5.0.1

Surely it would be in 5.1 according to semver

[HLeithner]

Already mentioned it somewhere that darkmode will be fixed within the patch releases, as long as the impact is not too big.

[brianteeman]

Already mentioned it somewhere that darkmode will be fixed within the patch releases, as long as the impact is not too big.

obviously havent seen that but anyway this pr is way more than a low impact patch

[HLeithner]

our b/c policy doesn't apply to html and css never the less we will see if it can be merged or not when 5.0 is out.

[brianteeman]

our b/c policy doesn't apply to html and css never the less we will see if it can be merged or not when 5.0 is out.

semver still applies

[MacJoom]

I have a question. How do you turn dark mode off? Nowhere to be found...

There is a plugin for Firefox "Toggle dark mode" https://github.com/Cimbali/toggle-dark-mode

I use it

[Milo-W]

I saw the much advertised ver. 2.0 of the dark mode... I hope there's a switch for light mode?

[coolcat-creations]

Yes there is a switch in 5.1

[dautrich]

Yes there is a switch in 5.1

.... but it is perfectly hidden: You have to go to Templates: Stile (Administrator), open Atum, and Save again (you need not change anything). After that, the switch appears in the User Menu.

This is a bug, which will most probably be corrected in J5.1.1. Then the switch will be in the User Menu per default.

[coolcat-creations]

I am not aware its a bug. I thought its because of b/c

[brianteeman]

I has been resolved with #43310 for 5.1.1

[Milo-W]

OK so waiting for 5.1.1 ; ) Thank you, Team!

[brianteeman]

no need to wait!! Just follow the instructions #42010 (comment)