Skip to content

Comments

[#42733] Fixes menu verification check for menu types with Unicode characters#42741

Merged
MacJoom merged 2 commits intojoomla:4.4-devfrom
Kubik-Rubik:fix-menu-verification
Feb 5, 2024
Merged

[#42733] Fixes menu verification check for menu types with Unicode characters#42741
MacJoom merged 2 commits intojoomla:4.4-devfrom
Kubik-Rubik:fix-menu-verification

Conversation

@Kubik-Rubik
Copy link
Member

Pull Request for Issue #42733.

Summary of Changes

This small change fixes the menu verification check for menu types with Unicode characters, such as German umlauts (ä, ü, ö).

Testing Instructions

  1. Enable the option "Unicode Aliases" in the global settings
  2. Create a new menu with the name "Menü" and the unique name "menü"
  3. Open the "All Menu Items" page and select the newly created menu from the drop-down list

Actual result BEFORE applying this Pull Request

You will see the error "The Menu type doesn't exist." and all menu items are loaded.

Expected result AFTER applying this Pull Request

No error is displayed, and the correct menu items are loaded.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@ghost
Copy link

ghost commented Feb 1, 2024

I have tested this item ✅ successfully on a8ee968


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42741.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 1, 2024

I have tested this item ✅ successfully on a8ee968


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42741.

@Quy
Copy link
Contributor

Quy commented Feb 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42741.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 1, 2024
@MacJoom MacJoom self-assigned this Feb 5, 2024
@MacJoom MacJoom added this to the Joomla 4.4.3 milestone Feb 5, 2024
@MacJoom MacJoom merged commit c123124 into joomla:4.4-dev Feb 5, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Feb 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants