[#42733] Fixes menu verification check for menu types with Unicode characters#42738
Closed
Kubik-Rubik wants to merge 1 commit intojoomla:5.1-devfrom
Closed
[#42733] Fixes menu verification check for menu types with Unicode characters#42738Kubik-Rubik wants to merge 1 commit intojoomla:5.1-devfrom
Kubik-Rubik wants to merge 1 commit intojoomla:5.1-devfrom
Conversation
Contributor
|
Rebase for v4.4? |
Member
|
If it’s a bug fix and the bug is also present in 4.4-dev it should indeed be fixed in 4.4-dev and will be merged up into 5.0-dev and 5.1-dev by the release managers. |
|
Bug in 4.4.2:
|
Kubik-Rubik
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo,
rdeutz and
zero-24
as code owners
Member
Author
|
PR against 4.4-dev: #42741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42733.
Summary of Changes
This small change fixes the menu verification check for menu types with Unicode characters, such as German umlauts (ä, ü, ö).
Testing Instructions
Actual result BEFORE applying this Pull Request
You will see the error "The Menu type doesn't exist." and all menu items are loaded.
Expected result AFTER applying this Pull Request
No error is displayed, and the correct menu items are loaded.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed