[5.3] FIX calendar picker if weeknumbers hidden and time format 24h

[cyrez]

Pull Request for Issue introduced (by me 🥇 ) in PR #40761.

Affected Joomla versions: 4.4.0 and 5.0.0

Summary of Changes

Quick FIX : Time select broken if calendar form field has weeknumbers attribute on false.

Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).

Testing Instructions

Set 2 form fields of type calendar like this (with and without week numbers):

Note: default timeformat is 24 and default weeknumbers is true.

<field
	name="no_week_numbers"
	type="calendar"
	label="Test"
	description="Test without weeknumbers and time 24h"
	translateformat="true"
	showtime="true"
	weeknumbers="false"
/>

<field
	name="week_numbers"
	type="calendar"
	label="Test"
	description="Test with weeknumbers and time 24h"
	translateformat="true"
    showtime="true"
/>

Actual result BEFORE applying this Pull Request

You can't change Time (hour and/or minutes) with the no_week_numbers calendar picker.
It's working with the other form field.

Note

EDIT 2025-08-23 PBF
The issue is if weeknumbers attribute is set to false you can change the time, click on close, but the time is not changed. Still the previous time display, not the new one.

Expected result AFTER applying this Pull Request

It's working in both cases.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[exlemor]

I have tested this item 🔴 unsuccessfully on 4c1d10b

Sadly... ;( I tried it twice and failed both times... I could NOT replicate the BEFORE (or AFTER) condition - the fields DID show up from the .xml in my plugin!

BUT without the PR applied, NONE of the 2 date pickers showed the time. (And even after the Download Package was applied with the PR rolled in), NEITHER of the 2 date pickers showed the time ;( ;(

Sorry @cyrezdev

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42185.}

[cyrez]

When you have applied patch @exlemor, did the calendar.js and calendar.min.js were updated as well in media/system/js/ folder?

[cyrez]

Imo, it's possible that i didn't explain clearly enough the issue. (2 years ago...)

So, before to patch, if you set add attribute "weeknumbers=false", you can see time, select one, but if you change it, click on close, it won't be saved.
This is what this patch is supposed to fix.

Simple example:
A. Before patch, open an existed article, go to created date field, open calendar picker and change the time, then click on close. Result the time is changed.
Then, edit article.xml and add weeknumbers=false to the "created" form field.
Try again A.
There, you may see that the time field is not update. You just can't. (just tested it while chilling in the garden).

B. Apply the patch, test A. with weeknumbers=false

[cyrez]

I've update PR with a Note to add better instruction. Hope this helps?

[exlemor]

I have tested this item ✅ successfully on 4c1d10b

I have tested this successfully - thank you @cyrezdev for doing Garden style PBF and fixing the Testing Instructions so we can get past the finish line 💜

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42185.}

[SumCompanyInc]

I have tested this item ✅ successfully on 4c1d10b

works for me!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42185.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42185.}

[rdeutz]

Thanks