FIX calendar picker if weeknumbers hidden and time format 24h

[cyrez]

Pull Request for Issue introduced (by me 🥇 ) in PR #40761.

Affected Joomla versions: 4.4.0 and 5.0.0

Summary of Changes

Quick FIX
Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).

Testing Instructions

Set 2 form fields of type calendar like this (with and without week numbers):

Note: default timeformat is 24 and dedault weeknumbers is true.

<field
	name="no_week_numbers"
	type="calendar"
	label="Test"
	description="Test without weeknumbers and time 24h"
	showtime="true"
	weeknumbers="false"
/>

<field
	name="week_numbers"
	type="calendar"
	label="Test"
	description="Test with weeknumbers and time 24h"
	showtime="true"
/>

Actual result BEFORE applying this Pull Request

You can't change Time (hour and/or minutes) with the no_week_numbers calendar picker.
It's working with the other form field.

Expected result AFTER applying this Pull Request

It's working in both cases.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

As it is a bug fix which is also relevant for 4.4, this pull request should be rebased or redone for the 4.4-dev branch. Maintainers will merge it up to 5.0-dev when it has been merged in 4.4-dev.

[cyrez]

Thanks @richard67 !

I will close this PR in favor of this new one: #42185

[richard67]

Thanks to you for the PR, @cyrezdev .