Skip to content

Comments

[5.0] Fix doubled Toolbar for modal views#41600

Merged
HLeithner merged 4 commits intojoomla:5.0-devfrom
Fedik:toolbar-modal
Sep 12, 2023
Merged

[5.0] Fix doubled Toolbar for modal views#41600
HLeithner merged 4 commits intojoomla:5.0-devfrom
Fedik:toolbar-modal

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Sep 5, 2023

Pull Request for Issue #41572, #41578 .

Summary of Changes

The patch renders toolbar in tmpl/modal.php layout, instead of in global component.php

Testing Instructions

Edit menu for Single Article, use modal select, create, edit for article.
Aslo try menu for Category, Contact, Newsfeed.

Edit an article, select an image in Media. Repeat it in front-end.

Also try to add a module to dashboard.

Actual result BEFORE applying this Pull Request

There a doubled toolbars.

Expected result AFTER applying this Pull Request

No doubled toolbar.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@Fedik Fedik added the bug label Sep 5, 2023
@richard67
Copy link
Member

I have tested this item ✅ successfully on 2a6f1be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

@Quy
Copy link
Contributor

Quy commented Sep 6, 2023

For Create Article, buttons should be in the footer.

41600-header

like the following:

41600-footer

@Fedik
Copy link
Member Author

Fedik commented Sep 6, 2023

For Create Article, buttons should be in the footer.

Nope. It is new, part of

Other modals currently still use Bootstrap, and should be transformed in future.

@Quy
Copy link
Contributor

Quy commented Sep 6, 2023

I have tested this item ✅ successfully on 2a6f1be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

@Quy
Copy link
Contributor

Quy commented Sep 6, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 6, 2023
@HLeithner HLeithner merged commit bc2c0d8 into joomla:5.0-dev Sep 12, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2023
@Fedik Fedik deleted the toolbar-modal branch September 12, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants