[5.0] Fix doubled Toolbar for modal views#41600
Merged
HLeithner merged 4 commits intojoomla:5.0-devfrom Sep 12, 2023
Merged
Conversation
4 tasks
richard67
reviewed
Sep 5, 2023
richard67
reviewed
Sep 5, 2023
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Quy
reviewed
Sep 5, 2023
Member
|
I have tested this item ✅ successfully on 2a6f1be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600. |
Contributor
Member
Author
Nope. It is new, part of Other modals currently still use Bootstrap, and should be transformed in future. |
Contributor
|
I have tested this item ✅ successfully on 2a6f1be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600. |
This was referenced Sep 7, 2023
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request for Issue #41572, #41578 .
Summary of Changes
The patch renders toolbar in tmpl/modal.php layout, instead of in global component.php
Testing Instructions
Edit menu for Single Article, use modal select, create, edit for article.
Aslo try menu for Category, Contact, Newsfeed.
Edit an article, select an image in Media. Repeat it in front-end.
Also try to add a module to dashboard.
Actual result BEFORE applying this Pull Request
There a doubled toolbars.
Expected result AFTER applying this Pull Request
No doubled toolbar.
Link to documentations
Please select:
Reference: