[5.0] Fix, Hide toolbar in modal when it not in use

[Fedik]

Pull Request for Issue #41572 .

Summary of Changes

Hide toolbar on empty state, in modal.
Because $this->setLayout('emptystate'); override the layout value the condition if ($this->getLayout() !== 'modal') never work.

Testing Instructions

On installation without articles.
Try select an article for menu. Also Category, Contact, Tags

Also try to add a module to dashboard.

Actual result BEFORE applying this Pull Request

You get a toolbar in modal

Expected result AFTER applying this Pull Request

No toolbar

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

Reference:

• [5.0] Generic ModalSelect field #40462

[richard67]

I have tested this item ✅ successfully on 63b034b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.}

[heelc29]

I have tested this item ✅ successfully on 63b034b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.}

[Fedik]

Wait, @obuisard found double toolbar in media modal.

[Fedik]

Should be good now also for Media.
Can only re-test "image select" while aricle editing

[richard67]

Back to pending.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.}

[obuisard]

Fedir @Fedik the media modal is now working properly

[obuisard]

Got 3 different results while testing after an update, trying now on new install (new install fails with Class "Joomla\Plugin\Behaviour\Taggable\Extension\Taggable" not found so updating the branch).

[Fedik]

Got 3 different results while testing after an update

✅ "New article" uses new ModalField, so it is okay ,
✅ "New contact" uses old ModalField, so it also okay ,
❌ "New newsfeed" uses old ModalField, and it need to fix the toolbar,

[obuisard]

Got 3 different results while testing after an update

✅ "New article" uses new ModalField, so it is okay , ✅ "New contact" uses old ModalField, so it also okay , ❌ "New newsfeed" uses old ModalField, and it need to fix the toolbar,

I confirm. Also
✅ "New categories"

Could not find where tags could be created in modal.

[Fedik]

newsfeed should be good now

[Quy]

Sorry to nitpick. In the other files, you assigned it to $isModal.

[Fedik]

it need there, because emptystate layout, and here it not in use

[Fedik]

I will set it as Draft for now.
There other related issues, wich need to find a better approach.

[Fedik]

Please test alternative fix #41600