Skip to content

[5.0][Events] Module event classes#41413

Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom
Fedik:module-events3
Aug 21, 2023
Merged

[5.0][Events] Module event classes#41413
HLeithner merged 1 commit intojoomla:5.0-devfrom
Fedik:module-events3

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 21, 2023 •
edited
Loading

Rebased and squashed #41297

Summary of Changes

Implementing Event classes for Module events.
The pr depend from #41226

Affected events:

  • onRenderModule
  • onAfterRenderModule
  • onAfterRenderModules
  • onPrepareModuleList
  • onAfterModuleList
  • onAfterCleanModuleList

Backward compatibility break (not critical):

Affects onAfterRenderModules.
Because its is imposible to pass the event attribute by reference the event listener now should use
$event->getContent() and $event->setContent($content) when need to modify the output.

Testing Instructions

Apply patch. Check all works

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

@Fedik
Squashed commit of the following:
1063fe5 
commit d09385f
Merge: 7364bfd f796d52
Author: Fedik <getthesite@gmail.com>
Date:   Mon Aug 21 10:50:33 2023 +0300

    Merge branch '5.0-dev' into module-events

commit 7364bfd
Merge: 3beb20d e27121e
Author: Fedik <getthesite@gmail.com>
Date:   Mon Aug 21 10:49:45 2023 +0300

    Merge branch 'content-events' into module-events

     Conflicts:
    	libraries/src/Event/CoreEventAware.php

commit e27121e
Merge: 1e8b38b 0bf4b43
Author: Fedik <getthesite@gmail.com>
Date:   Mon Aug 21 10:44:56 2023 +0300

    Merge branch '5.0-dev' into content-events-fix

     Conflicts:
    	components/com_content/src/View/Article/HtmlView.php
    	libraries/src/Event/Content/ContentEvent.php
    	libraries/src/Event/CoreEventAware.php
    	libraries/src/HTML/Helpers/Content.php
    	libraries/src/MVC/Controller/FormController.php
    	libraries/src/MVC/Model/AdminModel.php
    	libraries/src/MVC/Model/FormBehaviorTrait.php
    	libraries/src/MVC/Model/FormModel.php

commit 1e8b38b
Author: Fedik <getthesite@gmail.com>
Date:   Thu Aug 17 12:03:08 2023 +0300

    reorder

commit 270e501
Author: Fedik <getthesite@gmail.com>
Date:   Thu Aug 17 12:00:09 2023 +0300

    AfterCleanCache Event

commit 18e6396
Author: Fedik <getthesite@gmail.com>
Date:   Thu Aug 17 11:42:29 2023 +0300

    Do not use deprecated method

commit 6dae1eb
Author: Fedik <getthesite@gmail.com>
Date:   Thu Aug 17 11:34:38 2023 +0300

    Update access to dispatcher

commit d4237cb
Merge: c7586b1 1e1d479
Author: Harald Leithner <leithner@itronic.at>
Date:   Wed Aug 16 20:19:26 2023 +0200

    Merge branch '5.0-dev' into content-events

commit c7586b1
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 15 10:00:53 2023 +0300

    Revert "Play safe, legacy extension may have not set the Dispatcher"

    This reverts commit d786b07.

commit d786b07
Author: Fedik <getthesite@gmail.com>
Date:   Mon Aug 14 19:46:30 2023 +0300

    Play safe, legacy extension may have not set the Dispatcher

commit 810c56f
Author: Fedik <getthesite@gmail.com>
Date:   Mon Aug 14 18:40:07 2023 +0300

    phpcs

commit 9d51815
Merge: 9e69543 5ddaa20
Author: Harald Leithner <leithner@itronic.at>
Date:   Mon Aug 14 17:02:20 2023 +0200

    Merge branch '5.0-dev' into content-events

commit 9e69543
Author: Fedik <getthesite@gmail.com>
Date:   Sun Aug 6 17:12:49 2023 +0300

    Handle result

commit 3beb20d
Merge: 11e57fe 6e481d0
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 17:53:32 2023 +0300

    Merge branch 'content-events' into module-events

commit 6e481d0
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 17:42:03 2023 +0300

    Reorder

commit f1b9bf3
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 15:02:24 2023 +0300

    Updates

commit 50cfe0b
Merge: e591064 6deedde
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 14:53:00 2023 +0300

    Merge branch '5.0-dev' into content-events

commit e591064
Merge: 8908052 d3bda55
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 14:13:50 2023 +0300

    Merge branch '5.0-dev' into content-events

commit 8908052
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 14:13:31 2023 +0300

    Simplify

commit 2f837a5
Author: Fedik <getthesite@gmail.com>
Date:   Sat Aug 5 13:40:54 2023 +0300

    CategoryChangeState

commit 6220e42
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 19:21:02 2023 +0300

    b/c for get/set arguments

commit 11e57fe
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 14:10:43 2023 +0300

    Examples

commit d37e4db
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 14:06:10 2023 +0300

    ModuleListEvent

commit f6d0b83
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 14:05:47 2023 +0300

    ModuleListEvent

commit e768fca
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 13:55:08 2023 +0300

    ModuleListEvent

commit 0de8cf7
Author: Fedik <getthesite@gmail.com>
Date:   Tue Aug 1 13:11:32 2023 +0300

    RenderModuleEvent

commit ec9bf80
Author: Fedik <getthesite@gmail.com>
Date:   Mon Jul 31 19:31:16 2023 +0300

    RenderModuleEvent

commit 4b40348
Author: Fedik <getthesite@gmail.com>
Date:   Mon Jul 31 10:30:16 2023 +0300

    fixes

commit 441c7e0
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 15:29:19 2023 +0300

    Better reshape

commit 555a4e8
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 12:32:57 2023 +0300

    Fix mixed events

commit a03ff75
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 12:23:01 2023 +0300

    Fix mixed events

commit 0e4ce93
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 12:13:08 2023 +0300

    Schemaorg plg

commit 8e530da
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 11:35:56 2023 +0300

    testing test

commit 47291f0
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 11:34:41 2023 +0300

    Revert "testing test"

    This reverts commit 4a6064f.

commit 4a6064f
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 11:13:26 2023 +0300

    testing test

commit 8878acf
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 10:56:19 2023 +0300

    testing test

commit de60af5
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 10:45:38 2023 +0300

    testing test

commit 95b1a96
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 10:43:25 2023 +0300

    testing test

commit bfa4525
Author: Fedik <getthesite@gmail.com>
Date:   Sat Jul 29 10:41:39 2023 +0300

    testing test

commit a819701
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 15:45:30 2023 +0300

    Revert "testing test drone system"

    This reverts commit e48e0c0.

commit e48e0c0
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 15:18:03 2023 +0300

    testing test drone system

commit c75a44d
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 15:00:59 2023 +0300

    testing test

commit fea0f4f
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:53:05 2023 +0300

    testing test

commit e05d81e
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:42:55 2023 +0300

    testing test

commit 413f857
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:32:59 2023 +0300

    testing test

commit 61c8d16
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:24:14 2023 +0300

    testing test

commit 9f9cb05
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:23:14 2023 +0300

    testing test

commit 48fc17f
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:14:19 2023 +0300

    testing test

commit 1e6942f
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 14:01:53 2023 +0300

    testing test

commit 01a0f96
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 13:52:23 2023 +0300

    testing test

commit fa12d96
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 13:40:20 2023 +0300

    testing test

commit fcaba73
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 13:30:08 2023 +0300

    testing test

commit 0b94fc5
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 13:20:02 2023 +0300

    testing test

commit 429774f
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 13:08:38 2023 +0300

    testing test

commit 87b43a6
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:57:47 2023 +0300

    testing test

commit d41e53e
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:42:39 2023 +0300

    testing test

commit 1769788
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:33:50 2023 +0300

    testing test

commit cf0be84
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:23:50 2023 +0300

    testing test

commit 538565f
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:16:09 2023 +0300

    testing test

commit 25fee21
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 12:05:25 2023 +0300

    testing test

commit f4b2f18
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:59:17 2023 +0300

    testing test

commit 762baee
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:56:33 2023 +0300

    testing test

commit f22221e
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:49:00 2023 +0300

    testing test

commit db0277e
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:35:18 2023 +0300

    testing test

commit ef10d2b
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:16:28 2023 +0300

    testing test

commit 6866d42
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:14:34 2023 +0300

    Revert "testing test"

    This reverts commit 0134790.

commit 0134790
Author: Fedik <getthesite@gmail.com>
Date:   Fri Jul 28 11:08:02 2023 +0300

    testing test

commit 26eb8f2
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 19:02:06 2023 +0300

    Dates

commit 2d86862
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 18:44:00 2023 +0300

    Proxy event data

commit 38af7d5
Merge: 3e18ca7 b317289
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 18:35:16 2023 +0300

    Merge branch 'proxy-class' into content-events

commit 3e18ca7
Merge: 4e67381 a8e363d
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 18:35:08 2023 +0300

    Merge branch '5.0-dev' into content-events

commit b317289
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 18:34:01 2023 +0300

    Proxy Test

commit e17e974
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 14:38:59 2023 +0300

    Cleanup

commit 1eecbc7
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 14:37:51 2023 +0300

    Iterating own iterator

commit 1e477e3
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 14:05:46 2023 +0300

    ObjectProxy class

commit aef153b
Author: Fedik <getthesite@gmail.com>
Date:   Thu Jul 27 12:43:41 2023 +0300

    Proxy interface, ArrayProxy class

commit 4e67381
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 17:34:37 2023 +0300

    Plugin system/fields partial

commit c0596ab
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 16:22:45 2023 +0300

    Descriptions with example

commit 19f9a2b
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 16:07:52 2023 +0300

    Descriptions with example

commit 7b536b2
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 16:00:36 2023 +0300

    Re-arange

commit dcc7054
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 14:43:23 2023 +0300

    Re-arange

commit 8696272
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 13:52:30 2023 +0300

    Fix params

commit e46283c
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 13:41:24 2023 +0300

    Fix Data referencing

commit c888f2e
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 13:04:53 2023 +0300

    BeforeValidateData

commit de10615
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 12:51:29 2023 +0300

    ChangeStateEvent

commit 93d6c61
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 12:22:06 2023 +0300

    ContentDeleteEvent

commit 8feb26f
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 11:59:09 2023 +0300

    ContentSaveEvent

commit 3d7bb4f
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 11:49:36 2023 +0300

    Fixes for ContentBeforeSave

commit fd7f9a9
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 11:44:45 2023 +0300

    ContentAfterSave

commit 876badf
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 11:32:08 2023 +0300

    ContentBeforeSaveEvent

commit ea220f3
Author: Fedik <getthesite@gmail.com>
Date:   Wed Jul 26 10:41:36 2023 +0300

    Params b/c compatibility

commit 5acdf15
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 18:26:34 2023 +0300

    ContentNormaliseRequestData

commit 416b885
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 17:39:17 2023 +0300

    ContentPrepareData

commit 63f1b96
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 17:05:17 2023 +0300

    PrepareForm

commit 7348762
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 17:02:52 2023 +0300

    PrepareForm

commit c070269
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 16:54:33 2023 +0300

    PrepareForm

commit 276d860
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 16:36:26 2023 +0300

    PrepareForm

commit 36d8057
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 15:25:45 2023 +0300

    phpcs

commit ede41c3
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 15:02:09 2023 +0300

    Fix category params

commit 1995a33
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 14:49:57 2023 +0300

    AfterTitle, BeforeDisplay, AfterDisplay

commit 592056f
Author: Fedik <getthesite@gmail.com>
Date:   Tue Jul 25 14:04:27 2023 +0300

    ContentPrepareEvent
@Fedik Fedik mentioned this pull request Aug 21, 2023
Closed
10 tasks
@Fedik Fedik added the Feature label Aug 21, 2023
@HLeithner HLeithner merged commit 8e67a87 into joomla:5.0-dev Aug 21, 2023
@HLeithner
Copy link
Member

HLeithner commented Aug 21, 2023

thanks

@Fedik Fedik deleted the module-events3 branch August 21, 2023 08:31
@Fedik Fedik added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Aug 21, 2023
This was referenced Aug 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fedik @HLeithner @joomla-cms-bot