[5.0][Events] Module event classes#41297
Closed
Fedik wants to merge 89 commits intojoomla:5.0-devfrom
Closed
Conversation
10 tasks
Member
Author
|
Git is messed up here, I made new PR #41413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implementing Event classes for Module events.
The pr depend from #41226
Affected events:
Backward compatibility break (not critical):
Affects
onAfterRenderModules.Because its is imposible to pass the event attribute by reference the event listener now should use
$event->getContent()and$event->setContent($content)when need to modify the output.Testing Instructions
Apply patch. Check all works
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: