Skip to content

[5.0][Events] Module event classes#41297

Closed
Fedik wants to merge 89 commits intojoomla:5.0-devfrom
Fedik:module-events
Closed

[5.0][Events] Module event classes#41297
Fedik wants to merge 89 commits intojoomla:5.0-devfrom
Fedik:module-events

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 1, 2023

Summary of Changes

Implementing Event classes for Module events.
The pr depend from #41226

Affected events:

  • onRenderModule
  • onAfterRenderModule
  • onAfterRenderModules
  • onPrepareModuleList
  • onAfterModuleList
  • onAfterCleanModuleList

Backward compatibility break (not critical):

Affects onAfterRenderModules.
Because its is imposible to pass the event attribute by reference the event listener now should use
$event->getContent() and $event->setContent($content) when need to modify the output.

Testing Instructions

Apply patch. Check all works

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: https://docs.joomla.org/Plugin/Events#Module
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik marked this pull request as draft August 1, 2023 11:19
@Fedik Fedik added Feature b/c break This item changes the behavior in an incompatible why. HEADS UP labels Aug 1, 2023
@Fedik Fedik changed the title [5.0] Module event classes [5.0][Events] Module event classes Aug 5, 2023
@Fedik Fedik mentioned this pull request Aug 21, 2023
10 tasks
@Fedik
Copy link
Member Author

Fedik commented Aug 21, 2023

Git is messed up here, I made new PR #41413

@Fedik Fedik closed this Aug 21, 2023
@Fedik Fedik deleted the module-events branch August 21, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments