Skip to content

[5.0] Fix drone failing due to PHPCS error unused import from PR #41322#41408

Merged
laoneo merged 1 commit intojoomla:5.0-devfrom
richard67:5.0-dev-fix-phpcs-unused-import
Aug 21, 2023
Merged

[5.0] Fix drone failing due to PHPCS error unused import from PR #41322#41408
laoneo merged 1 commit intojoomla:5.0-devfrom
richard67:5.0-dev-fix-phpcs-unused-import

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Aug 20, 2023

Pull Request for Issue # .

Summary of Changes

Currently drone is failing in the 5.0-dev branch since the merge of PR #41322 : https://ci.joomla.org/joomla/joomla-cms/68541/1/7

This PR here fixes that.

Testing Instructions

Check drone logs of this PR and of the last commit in the 5.0.-dev branch.

Actual result BEFORE applying this Pull Request

Drone PHPCS fails in the 5.0-dev branch.

Expected result AFTER applying this Pull Request

Drone PHPCS passes with this PR.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member Author

Ping @HLeithner .

@laoneo laoneo merged commit 2e7902f into joomla:5.0-dev Aug 21, 2023
@laoneo
Copy link
Member

laoneo commented Aug 21, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 5.0 milestone Aug 21, 2023
@laoneo
Copy link
Member

laoneo commented Aug 21, 2023

Merged as it blocks drone on the other pr's.

@richard67 richard67 deleted the 5.0-dev-fix-phpcs-unused-import branch August 21, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants