Skip to content

[5.0][Events] Extension and Installer event classes#41322

Merged
HLeithner merged 91 commits intojoomla:5.0-devfrom
Fedik:installer-events
Aug 20, 2023
Merged

[5.0][Events] Extension and Installer event classes#41322
HLeithner merged 91 commits intojoomla:5.0-devfrom
Fedik:installer-events

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 5, 2023

Summary of Changes

Implementing Event classes for Extension events.
The pr depend from #41226

Affected events:

  • onExtensionBeforeInstall
  • onExtensionAfterInstall
  • onExtensionBeforeUninstall
  • onExtensionAfterUninstall
  • onExtensionBeforeUpdate
  • onExtensionAfterUpdate

Uses generic classes from Joomla\Event\Model:

  • onExtensionBeforeSave
  • onExtensionAfterSave
  • onExtensionAfterDelete

Testing Instructions

Apply patch.
Try install, uninstall, update, edit extensions.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

@Fedik Fedik requested review from rdeutz and zero-24 as code owners August 5, 2023 14:31
@Fedik Fedik marked this pull request as draft August 5, 2023 14:31
@Fedik Fedik added the Feature label Aug 5, 2023
@HLeithner HLeithner marked this pull request as ready for review August 20, 2023 20:37
@HLeithner HLeithner merged commit a78c8f5 into joomla:5.0-dev Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
@Fedik
Copy link
Member Author

Fedik commented Aug 20, 2023

Please revert it.
#41226 should be merged first, and then other ones.
Or it will be a hell of conflicts

laoneo pushed a commit that referenced this pull request Aug 21, 2023
heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Aug 21, 2023
HLeithner pushed a commit that referenced this pull request Aug 22, 2023
* [5.0][Events] Schemaorg event classes

* cs

* remove unused import

* rename table argument due #41322

* cs

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants