Skip to content

[4.4] Events backward compatibility handling#41357

Merged
laoneo merged 1 commit intojoomla:4.4-devfrom
Fedik:events-fixes2
Aug 14, 2023
Merged

[4.4] Events backward compatibility handling#41357
laoneo merged 1 commit intojoomla:4.4-devfrom
Fedik:events-fixes2

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 13, 2023

Summary of Changes

Same as #41345 but for 4.4.
Fixing possible b/c break for an events.
I have extracted it from #41226 in to separated PR.

Testing Instructions

Apply patch.
Edit plugins/system/sef/src/Extension/Sef.php, add return true; at top of onAfterDispatch() function.
Run in index.php of a template:

$event = new class('onAfterDispatch') extends Joomla\CMS\Event\AbstractImmutableEvent{};
$app->getDispatcher()->dispatch('onAfterDispatch', $event);

Actual result BEFORE applying this Pull Request

An error, cannot set result for Imutable event

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

@Fedik Fedik added Feature bug Small A PR which only has a small change and removed Feature labels Aug 13, 2023
@HLeithner
Copy link
Member

I have tested this item ✅ successfully on d09f3e1

Works with patchtester which broke before


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41357.

@laoneo laoneo merged commit fcc7209 into joomla:4.4-dev Aug 14, 2023
@laoneo
Copy link
Member

laoneo commented Aug 14, 2023

Merging this now. Thanks @Fedik, can you write a manual entry for the deprecation notice?

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Aug 14, 2023
@Fedik Fedik deleted the events-fixes2 branch August 14, 2023 11:57
@Fedik
Copy link
Member Author

Fedik commented Aug 14, 2023

There it is joomla/Manual#169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PR-4.4-dev Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants