[4.4] Events backward compatibility handling#41357
Merged
laoneo merged 1 commit intojoomla:4.4-devfrom Aug 14, 2023
Merged
Conversation
4 tasks
Member
|
I have tested this item ✅ successfully on d09f3e1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41357. |
Member
|
Merging this now. Thanks @Fedik, can you write a manual entry for the deprecation notice? |
Member
Author
|
There it is joomla/Manual#169 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Same as #41345 but for 4.4.
Fixing possible b/c break for an events.
I have extracted it from #41226 in to separated PR.
Testing Instructions
Apply patch.
Edit
plugins/system/sef/src/Extension/Sef.php, addreturn true;at top ofonAfterDispatch()function.Run in index.php of a template:
Actual result BEFORE applying this Pull Request
An error, cannot set result for Imutable event
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select: