[5.0] Events backward compatibility handling#41345
Closed
Fedik wants to merge 3 commits intojoomla:5.0-devfrom
Closed
[5.0] Events backward compatibility handling#41345Fedik wants to merge 3 commits intojoomla:5.0-devfrom
Fedik wants to merge 3 commits intojoomla:5.0-devfrom
Conversation
20 tasks
Member
|
Would it make sense to check if the $name is a string and numeric? Actually only strings are allowed but we don't have a typehint for it... |
Member
Author
|
I think it is enought to check for "numeric", additional test for a string does not give us any extra value. |
laoneo
reviewed
Aug 12, 2023
Member
|
I would do this in 4.4 because it's not an intended behaviour (if we remove it in 6 then is another story) |
Member
Author
|
I can redo it to 4.4, no problem |
Fedik
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
fancyFranci,
rdeutz,
wilsonge and
zero-24
as code owners
4 tasks
Member
Author
|
PR for 4.4 #41357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I have extracted b/c fixes from #41226 in to separated PR.
Testing Instructions
Apply patch.
Edit
plugins/system/sef/src/Extension/Sef.php, addreturn trueat top of onAfterDispatch() function.Actual result BEFORE applying this Pull Request
An error, cannot set result for Imutable event
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select: